Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups #995

Merged
merged 9 commits into from
Dec 1, 2023
Merged

Cleanups #995

merged 9 commits into from
Dec 1, 2023

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

  • get rid of the PR check running on Node.JS 16;
  • cleanup dependencies.

Copy link

openshift-ci bot commented Nov 17, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@che-bot
Copy link
Contributor

che-bot commented Nov 17, 2023

Click here to review and test in web IDE: Contribute

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eab9a63) 86.40% compared to head (e16e24d) 85.17%.

❗ Current head e16e24d differs from pull request most recent head 70777cf. Consider uploading reports for the commit 70777cf to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #995      +/-   ##
==========================================
- Coverage   86.40%   85.17%   -1.23%     
==========================================
  Files         385      380       -5     
  Lines       39370    39198     -172     
  Branches     2583     2521      -62     
==========================================
- Hits        34017    33388     -629     
- Misses       5328     5784     +456     
- Partials       25       26       +1     
Flag Coverage Δ
unittests 85.17% <ø> (-1.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-995

1 similar comment
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-995

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-995

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-995", name: che-dashboard}]}}]"

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-995

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-995", name: che-dashboard}]}}]"

Copy link

github-actions bot commented Dec 1, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-995

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-995", name: che-dashboard}]}}]"

Signed-off-by: Oleksii Kurinnyi <[email protected]>
@openshift-ci openshift-ci bot added the lgtm label Dec 1, 2023
Copy link

openshift-ci bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akurinnoy akurinnoy merged commit 5a60d5d into main Dec 1, 2023
9 checks passed
@akurinnoy akurinnoy deleted the cleanup branch December 1, 2023 10:21
@devstudio-release
Copy link

Build 3.11 :: dashboard_3.x/415: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: dashboard_3.x/415: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5466 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: copyIIBsToQuay/2236: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: sync-to-downstream_3.x/5467: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5345 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.11 :: operator-bundle_3.x/2349: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5467 triggered

@devstudio-release
Copy link

Build 3.11 :: dsc_3.x/1615: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: update-digests_3.x/5088: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.x/2349 triggered

@devstudio-release
Copy link

Build 3.11 :: dsc_3.x/1615: SUCCESS

3.11.0-CI

@devstudio-release
Copy link

Build 3.11 :: dashboard_3.x/416: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: dashboard_3.x/416: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5477 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: update-digests_3.x/5108: UNSTABLE

No new images detected: nothing to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants