Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct community meetings wiki url #2769

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

richardkocian
Copy link
Contributor

@richardkocian richardkocian commented Aug 12, 2024

What does this pull request change?

Broken community meetings wiki URL. (The Che community meeting link currently leads to creating new wiki page, instead I would say it should lead there https://github.com/eclipse-che/che/wiki/Eclipse-Che-Community-Meetings)

What issues does this pull request fix or reference?

Specify the version of the product this pull request applies to

main (Eclipse Che 7.89.0)

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@richardkocian richardkocian requested review from deerskindoll and a team as code owners August 12, 2024 15:00
@richardkocian richardkocian requested a review from amisevsk August 12, 2024 15:00
Copy link

github-actions bot commented Aug 12, 2024

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Aug 12, 2024

⚡️ Deploying pull request preview...

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -55,7 +55,7 @@ Learn about the latest of {prod} and submit your blog posts to the link:https://

Weekly meetings::

Join us in the link:https://github.com/eclipse/che/wiki/{prod-short}-Dev-Meetings[{prod-short} community meeting] every Monday.
Join us in the link:https://github.com/eclipse/che/wiki/{prod-id}-community-meetings[{prod-short} community meeting] every Monday.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I changed it

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardkocian great catch, and thank you for the contribution but we need to update it based on new terms see - https://www.eclipse.org/lists/che-dev/msg04512.html
Please, update it accordingly

@richardkocian richardkocian force-pushed the community-meetings-fix branch from 27d5d32 to 3d6b4a9 Compare August 15, 2024 11:56
@richardkocian richardkocian requested a review from ibuziuk August 15, 2024 11:58
Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

congrats with the first contribution 🎉

@richardkocian
Copy link
Contributor Author

congrats with the first contribution 🎉

@ibuziuk Thanks! Could you please merge it? Because I see that I do not have enough permissions to do that

@deerskindoll deerskindoll merged commit 3873c64 into eclipse-che:main Oct 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants