Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in persistent home docs #2874

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

dkwon17
Copy link
Contributor

@dkwon17 dkwon17 commented Mar 5, 2025

What does this pull request change?

Fixes a typo in the persistent home documentation

What issues does this pull request fix or reference?

n/a

Specify the version of the product this pull request applies to

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@dkwon17 dkwon17 requested review from deerskindoll and a team as code owners March 5, 2025 16:03
@dkwon17 dkwon17 requested a review from amisevsk March 5, 2025 16:03
Copy link

github-actions bot commented Mar 5, 2025

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Mar 5, 2025

🎊 Navigate the preview: https://67c8d1574f752e1126fd84af--eclipse-che-docs-pr.netlify.app 🎊

Copy link
Contributor

@mkuznyetsov mkuznyetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍 just one suggestion

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deerskindoll
Copy link
Contributor

we'll be backporting this to 7.98, right?

@dkwon17
Copy link
Contributor Author

dkwon17 commented Mar 5, 2025

Yes, it should also be backported to the 7.98.x branch

@dkwon17 dkwon17 merged commit c47a409 into eclipse-che:main Mar 6, 2025
6 checks passed
dkwon17 added a commit to dkwon17/che-docs that referenced this pull request Mar 6, 2025
* fix: typo in persistent home docs

Signed-off-by: dkwon17 <[email protected]>

* Update modules/administration-guide/pages/about-persistent-user-home.adoc

Co-authored-by: Mykhailo Kuznietsov <[email protected]>

---------

Signed-off-by: dkwon17 <[email protected]>
Co-authored-by: Mykhailo Kuznietsov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants