Support Devfile endpoint annotations in Che Router #1881

AObuchow · 2024-08-13T03:45:00Z

What does this PR do?

Adds the DWR endpoint annotations as annotations for the route (on OpenShift) or ingresse (on Kubernetes) created by the Che Router for a given endpoint

There are a few additional changes made in this PR that are not meant to be merged, though they may be desirable:

Using per-workspace storage as well as the UDI in the Che-Operator devfile. This was helpful for developing this patch in Che.

Screenshot/screencast of this PR

n/a

What issues does this PR fix or reference?

Fix eclipse-che/che#23064

How to test this PR?

Install DWO built from this PR, as well as Che-Operator built from the current PR onto your cluster.

On OpenShift, this can easily be done by running ./build/scripts/olm/test-catalog-from-sources.sh from the root of this repo.
On minikube/kubernetes, you'll have to:
1. Build DWO: From the root of the DWO repo run export DWO_IMG=quay.io/<username>/devworkspace-controller:endpoint-annotations && make docker (or just use my image: export DWO_IMG=quay.io/<username>/devworkspace-controller:endpoint-annotations-implementation )
2. Install DWO: make install_cert_manager && make install
3. Build Che-Operator: make docker-build docker-push IMG=<YOUR_OPERATOR_IMAGE>
4. Install Che: chectl server:deploy -p minikube --che-operator-image=<YOUR_OPERATOR_IMAGE>

Once both DWO and Che are installed onto your cluster, verify there's a Che Cluster CR instance created so that you can access the Che User dashboard
From the Che User Dashboard, create a workspace with a devfile that defines endpoints with annotations, such as this one.

      endpoints:
        - name: https-python
          targetPort: 8080
          protocol: https
          annotation:
            my-annotation: test
            another-annotation: test2

Once the workspace has started up, verify the routes & ingresses for the endpoint(s) with annotations have the expected annotations from the devfile. In my example devfile, your <workspaceid>-py-8080-https-python route/ingress should have my-annotation: test & another-annotation: test2, as shown below:

kind: Route
apiVersion: route.openshift.io/v1
metadata:
  annotations:
+    another-annotation: test2
    che.routing.controller.devfile.io/component-name: py
    che.routing.controller.devfile.io/endpoint-name: https-python
+    my-annotation: test
  resourceVersion: '48291'
  name: workspace4b929cbc569a4473-py-8080-https-python
(...)
  namespace: che-kube-admin-che-rwxo67
  ownerReferences:
    - apiVersion: controller.devfile.io/v1alpha1
      kind: DevWorkspaceRouting
      name: routing-workspace4b929cbc569a4473
      uid: 497a6df3-9e14-47f8-9fc6-33acfda6df77
      controller: true
      blockOwnerDeletion: true
  labels:
    app.kubernetes.io/part-of: che.eclipse.org
    controller.devfile.io/devworkspace_id: workspace4b929cbc569a4473
spec:
(...)

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

openshift-ci · 2024-08-13T03:45:05Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

AObuchow · 2024-08-13T03:48:23Z

controllers/devworkspace/solver/endpoint_exposer.go

 	annos := map[string]string{}
 	for k, v := range ingressAnnotations {
 		annos[k] = v
 	}
+	for k, v := range endpointAnnotations {
+		annos[k] = v


Note: the devfile endpoint annotations can actually override the values of the Che Cluster CR ingress annotations. To me, this makes sense, as it gives users more fine-grained control over the ingress annotations. However, I don't have a strong opinion on this.

I realized we are not adding annotations from the Che Cluster CR's networking.annotations fields to the routes created by the Che Router, only the ingresses get these annotations.

This seems like a bug or an error in the documentation, so I've opened eclipse-che/che#23118 to track this. If this is indeed a bug, I could add the fix as part of this PR since it's closely related.

AObuchow · 2024-08-27T17:29:53Z

@tolusha Though this PR is still a draft, it should be good for review if you want to take a look already. In order for this PR to no longer be a draft, we'll need to release DWO 0.31.0, and I'll update this PR to pull in the latest version of DWO

tolusha · 2024-08-28T14:10:08Z

Sounds good for me

AObuchow · 2024-09-12T14:29:41Z

@tolusha the DWO 0.31.0 release is currently in progress. Once it's released, I will update this PR and it will be ready for review :)

AObuchow · 2024-09-19T14:59:23Z

@tolusha this PR is finally ready for review now that DWO 0.31.0 is being used in Che-Operator :)

AObuchow · 2024-09-19T15:04:15Z

@tolusha by the way, if you end up wanting the devfile changes, I'll rewrite the commit messages for them (since they're currently marked as "do not merge").

AObuchow · 2024-09-19T15:12:48Z

/retest-required

AObuchow · 2024-09-19T16:20:37Z

/retest-required

AObuchow · 2024-09-19T17:02:07Z

/retest-required

AObuchow · 2024-09-19T18:22:35Z

Not sure why the pro v14-che-behind-proxy test is failing, though it seems unrelated to this PR:

INFO[2024-09-19T17:04:27Z] Logs for container test in pod che-behind-proxy-ipi-conf-aws-blackholenetwork: 
INFO[2024-09-19T17:04:27Z] 
An error occurred (AlreadyExistsException) when calling the CreateStack operation: Stack [ci-op-mfqq3b2j-9dadd-shared-vpc-blackhole] already exists
{"component":"entrypoint","error":"wrapped process failed: exit status 254","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2024-09-19T17:04:27Z"}
error: failed to execute wrapped command: exit status 254 
INFO[2024-09-19T17:04:27Z] Step che-behind-proxy-ipi-conf-aws-blackholenetwork failed after 9s. 
(...)
INFO[2024-09-19T17:06:58Z] Ran for 4m36s                                
ERRO[2024-09-19T17:06:58Z] Some steps failed:                           
ERRO[2024-09-19T17:06:58Z] 
  * could not run steps: step che-behind-proxy failed: "che-behind-proxy" pre steps failed: "che-behind-proxy" pod "che-behind-proxy-ipi-conf-aws-blackholenetwork" failed: could not watch pod: the pod ci-op-mfqq3b2j/che-behind-proxy-ipi-conf-aws-blackholenetwork failed after 7s (failed containers: test): ContainerFailed one or more containers exited
Container test exited with code 254, reason Error
---
An error occurred (AlreadyExistsException) when calling the CreateStack operation: Stack [ci-op-mfqq3b2j-9dadd-shared-vpc-blackhole] already exists
{"component":"entrypoint","error":"wrapped process failed: exit status 254","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2024-09-19T17:04:27Z"}
error: failed to execute wrapped command: exit status 254
---

ibuziuk · 2024-09-20T13:13:47Z

/retest

tolusha · 2024-09-20T13:25:48Z

devfile.yaml

 metadata:
  name: che-operator
 components:
  - name: tooling-container
    container:
-      image: quay.io/eclipse/che-operator-dev:latest
+      image: quay.io/devfile/universal-developer-image:ubi8-latest


Please, revert this line.
dev image is based on quay.io/devfile/universal-developer-image:ubi8-latest

Done, I removed the associated commit. However, the reason why I changed the image being used is because the che-operator-dev container image is outdated and needs to be rebuilt to pull in the latest changes from the UDI.

tolusha · 2024-09-20T13:32:58Z

controllers/devworkspace/solver/endpoint_exposer.go

 }

-func finalizeIngressAnnotations(ingressAnnotations map[string]string, machineName string, endpointName string) map[string]string {
+func finalizeIngressAnnotations(ingressAnnotations, endpointAnnotations map[string]string, machineName string, endpointName string) map[string]string {


Is the order of parameters ingressAnnotations and endpointAnnotations correct?

Yes: ingressAnnotations refers to the annotations to add to the ingress provided by the Che Cluster CR, and endpointAnnotatiosn refers to the annotations provided by the devfile. It's worth ensuring we want the devfile annotations to be able to override the Che Cluster CR annotations, see https://github.com/eclipse-che/che-operator/pull/1881/files#r1714630847

When we call this function, we're first providing the IngressExposer's annotations (coming from the Che Cluster CR, see the last parameter of this function call) and then the endpoint's annotations (coming from the devfile through the devworkspace routing's endpoint)

Annotations: finalizeIngressAnnotations(endpoint.annotations, e.ingressAnnotations, endpoint.componentName, endpoint.endpointName),

Hopefully this clarifies things - let me know if I misinterpreted your question.

In line 201, should it be the other way around, like this?

Annotations: finalizeIngressAnnotations(e.ingressAnnotations, endpoint.annotations, endpoint.componentName, endpoint.endpointName),

Ah I see now, can't believe I made that mistake. Good catch @tolusha @dkwon17 I'll fix this immediately 👍

Should be good now, see d6c1724.

Once verified and approved, I'll squash the fixup commit :)

AObuchow · 2024-09-23T19:52:11Z

/retest-required

AObuchow · 2024-09-23T19:57:44Z

/retest-required

AObuchow · 2024-09-23T20:08:48Z

/retest-required

Signed-off-by: Andrew Obuchowicz <[email protected]>

…resses Fix eclipse-che/che#23064 Signed-off-by: Andrew Obuchowicz <[email protected]>

Signed-off-by: Andrew Obuchowicz <[email protected]>

openshift-ci · 2024-09-23T21:15:10Z

@AObuchow: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v14-che-behind-proxy	`c0afbf9`	link	true	`/test v14-che-behind-proxy`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

devstudio-release · 2024-09-23T23:11:43Z

Build 3.17 :: operator_3.x/404: Console, Changes, Git Data

devstudio-release · 2024-09-23T23:13:53Z

Build 3.17 :: sync-to-downstream_3.x/7729: Console, Changes, Git Data

devstudio-release · 2024-09-23T23:18:48Z

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7723: Console, Changes, Git Data

devstudio-release · 2024-09-23T23:40:57Z

Build 3.17 :: push-latest-container-to-quay_3.x/4936: Console, Changes, Git Data

devstudio-release · 2024-09-23T23:42:37Z

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7723:

devspaces-operator : 3.x :: Build 64454618 : quay.io/devspaces/devspaces-rhel8-operator:3.17-15
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/4936 triggered

devstudio-release · 2024-09-23T23:42:41Z

Build 3.17 :: operator_3.x/404:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7729 triggered

devstudio-release · 2024-09-23T23:42:46Z

Build 3.17 :: update-digests_3.x/7609: Console, Changes, Git Data

devstudio-release · 2024-09-23T23:43:36Z

Build 3.17 :: operator-bundle_3.x/3619: Console, Changes, Git Data

devstudio-release · 2024-09-23T23:50:42Z

Build 3.17 :: sync-to-downstream_3.x/7730: Console, Changes, Git Data

devstudio-release · 2024-09-23T23:55:48Z

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7724: Console, Changes, Git Data

devstudio-release · 2024-09-24T00:08:18Z

Build 3.17 :: push-latest-container-to-quay_3.x/4937: Console, Changes, Git Data

devstudio-release · 2024-09-24T00:10:08Z

Build 3.17 :: copyIIBsToQuay/2802: Console, Changes, Git Data

devstudio-release · 2024-09-24T00:10:47Z

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7724:

devspaces-operator-bundle : 3.x :: Build 64455438 : quay.io/devspaces/devspaces-operator-bundle:3.17-16
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/4937 triggered;
Bundle CSV related images:
- quay.io/devspaces/code-rhel8:3.17-11
- quay.io/devspaces/configbump-rhel8:3.17-2
- quay.io/devspaces/dashboard-rhel8:3.17-10
- quay.io/devspaces/devspaces-rhel8-operator:3.17-15
- quay.io/devspaces/idea-rhel8:3.17-1
- quay.io/devspaces/pluginregistry-rhel8:3.17-6
- quay.io/devspaces/server-rhel8:3.17-4
- quay.io/devspaces/traefik-rhel8:3.17-2
- quay.io/devspaces/udi-rhel8:3.17-2
= registry.redhat.io/devspaces/udi-rhel8:3.15-5.1724033655
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.14.0-202408260910.p0.g1a646b9.assembly.stream.el8
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.14.0-202408260910.p0.ga4a2f27.assembly.stream.el8
= registry.redhat.io/rhscl/mongodb-36-rhel7:1-50
= registry.redhat.io/ubi8/ubi-minimal:8.8-1072.1697626218

devstudio-release · 2024-09-24T00:10:49Z

Build 3.17 :: sync-to-downstream_3.x/7730:

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/7724 triggered; /job/DS_CI/job/dsc_3.x triggered;

devstudio-release · 2024-09-24T00:10:50Z

Build 3.17 :: operator-bundle_3.x/3619:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7730 triggered

devstudio-release · 2024-09-24T00:12:12Z

Build 3.17 :: dsc_3.x/2005: Console, Changes, Git Data

devstudio-release · 2024-09-24T00:12:46Z

Build 3.17 :: update-digests_3.x/7609:

Detected new images: rebuild operator-bundle
* devspaces-operator; /DS_CI/operator-bundle_3.x/3619 triggered

devstudio-release · 2024-09-24T00:20:30Z

Build 3.17 :: dsc_3.x/2005:

3.17.0-CI

devstudio-release · 2024-09-24T00:46:59Z

Build 3.17 :: copyIIBsToQuay/2802:

3.17
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.17-16
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:???
+ x86_64-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.17-v4.17-821034- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.17-v4.17-821034- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.17-v4.17-x86_64
  + <a href=https://quay.io/devspaces/iib:3.17-v4.16-821035- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.17-v4.16-821035- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.17-v4.16-x86_64
  + <a href=https://quay.io/devspaces/iib:3.17-v4.15-823183- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.17-v4.15-823183- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.17-v4.15-x86_64
  + <a href=https://quay.io/devspaces/iib:3.17-v4.14-823181- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.17-v4.14-823181- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.17-v4.14-x86_64
  + <a href=https://quay.io/devspaces/iib:3.17-v4.13-823180- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.17-v4.13-823180- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.17-v4.13-x86_64
  + <a href=https://quay.io/devspaces/iib:3.17-v4.12-823203- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.17-v4.12-823203- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.17-v4.12-x86_64
+ s390x-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.17-v4.17-821034- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.17-v4.17-821034- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.17-v4.17-s390x
  + <a href=https://quay.io/devspaces/iib:3.17-v4.16-821035- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.17-v4.16-821035- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.17-v4.16-s390x
  + <a href=https://quay.io/devspaces/iib:3.17-v4.15-823183- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.17-v4.15-823183- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.17-v4.15-s390x
  + <a href=https://quay.io/devspaces/iib:3.17-v4.14-823181- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.17-v4.14-823181- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.17-v4.14-s390x
  + <a href=https://quay.io/devspaces/iib:3.17-v4.13-823180- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.17-v4.13-823180- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.17-v4.13-s390x
  + <a href=https://quay.io/devspaces/iib:3.17-v4.12-823203- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.17-v4.12-823203- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.17-v4.12-s390x
+ ppc64le-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.17-v4.17-821034- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.17-v4.17-821034- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.17-v4.17-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.17-v4.16-821035- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.17-v4.16-821035- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.17-v4.16-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.17-v4.15-823183- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.17-v4.15-823183- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.17-v4.15-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.17-v4.14-823181- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.17-v4.14-823181- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.17-v4.14-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.17-v4.13-823180- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.17-v4.13-823180- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.17-v4.13-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.17-v4.12-823203- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.17-v4.12-823203- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.17-v4.12-ppc64le

openshift-ci bot added the do-not-merge/work-in-progress label Aug 13, 2024

AObuchow commented Aug 13, 2024

View reviewed changes

AObuchow changed the title ~~Endpoint annotations che routing implementation~~ Support Devfile endpoint annotations in Che Router Aug 13, 2024

AObuchow force-pushed the endpoint-annotations-che-routing-implementation branch from 0897b54 to 7cb6d74 Compare September 19, 2024 14:54

AObuchow marked this pull request as ready for review September 19, 2024 14:58

AObuchow requested review from SDawley, tolusha and ibuziuk as code owners September 19, 2024 14:58

openshift-ci bot removed the do-not-merge/work-in-progress label Sep 19, 2024

AObuchow mentioned this pull request Sep 20, 2024

Use endpoint-specific service for discoverable endpoints #1903

Merged

10 tasks

ibuziuk approved these changes Sep 20, 2024

View reviewed changes

openshift-ci bot assigned ibuziuk Sep 20, 2024

openshift-ci bot added the lgtm label Sep 20, 2024

tolusha reviewed Sep 20, 2024

View reviewed changes

AObuchow force-pushed the endpoint-annotations-che-routing-implementation branch from 7cb6d74 to 0fe0757 Compare September 22, 2024 18:35

openshift-ci bot removed the lgtm label Sep 22, 2024

dkwon17 approved these changes Sep 23, 2024

View reviewed changes

openshift-ci bot assigned dkwon17 Sep 23, 2024

openshift-ci bot added the lgtm label Sep 23, 2024

AObuchow added 3 commits September 23, 2024 17:00

chore: use per-workspace storage for Che-Operator devfile

d5243b7

Signed-off-by: Andrew Obuchowicz <[email protected]>

feat: Add DWR endpoint annotations to che router created routes & ing…

d9aaac4

…resses Fix eclipse-che/che#23064 Signed-off-by: Andrew Obuchowicz <[email protected]>

chore: Add Che Routing tests for devfile endpoint annotations

c0afbf9

Signed-off-by: Andrew Obuchowicz <[email protected]>

AObuchow force-pushed the endpoint-annotations-che-routing-implementation branch from 22e1bd3 to c0afbf9 Compare September 23, 2024 21:00

AObuchow mentioned this pull request Sep 23, 2024

Do not merge: no-op commit to test prow CI #1905

Merged

10 tasks

AObuchow merged commit 6164f7b into eclipse-che:main Sep 23, 2024
18 of 19 checks passed

AObuchow mentioned this pull request Oct 24, 2024

All endpoints (ingress) have the same secretName eclipse-che/che#22935

Open

Support Devfile endpoint annotations in Che Router #1881

Support Devfile endpoint annotations in Che Router #1881

Conversation

AObuchow commented Aug 13, 2024 • edited Loading

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Reviewers

openshift-ci bot commented Aug 13, 2024

AObuchow Aug 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AObuchow commented Aug 27, 2024

tolusha commented Aug 28, 2024

AObuchow commented Sep 12, 2024

AObuchow commented Sep 19, 2024

AObuchow commented Sep 19, 2024

AObuchow commented Sep 19, 2024

AObuchow commented Sep 19, 2024

AObuchow commented Sep 19, 2024

AObuchow commented Sep 19, 2024

ibuziuk commented Sep 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AObuchow commented Sep 23, 2024

AObuchow commented Sep 23, 2024

AObuchow commented Sep 23, 2024

openshift-ci bot commented Sep 23, 2024 • edited Loading

devstudio-release commented Sep 23, 2024

devstudio-release commented Sep 23, 2024

devstudio-release commented Sep 23, 2024

devstudio-release commented Sep 23, 2024

devstudio-release commented Sep 23, 2024

devstudio-release commented Sep 23, 2024

devstudio-release commented Sep 23, 2024

devstudio-release commented Sep 23, 2024

devstudio-release commented Sep 23, 2024

devstudio-release commented Sep 23, 2024

devstudio-release commented Sep 24, 2024

devstudio-release commented Sep 24, 2024

devstudio-release commented Sep 24, 2024

devstudio-release commented Sep 24, 2024

devstudio-release commented Sep 24, 2024

devstudio-release commented Sep 24, 2024

devstudio-release commented Sep 24, 2024

devstudio-release commented Sep 24, 2024

devstudio-release commented Sep 24, 2024

AObuchow commented Aug 13, 2024 •

edited

Loading

AObuchow Aug 13, 2024 •

edited

Loading

openshift-ci bot commented Sep 23, 2024 •

edited

Loading