Use HTTP response status code to check gitlab repositories accessibil… #742
Conversation
…ity (#741) Improve the isPublicRepository() function in the GitlabAuthorizingFileContentProvider class to check the http response status code. The previous way with the urlFetcher does not work because gitlab server returns a content of an html page with credentials input instead of an error.
vinokurig
force-pushed
the
CRW-7608-7.92
branch
from
ddf8b72
to
bfca617
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dmytro-ndp, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build 3.17 :: server_3.17/6: Console, Changes, Git Data |
|
Build 3.17 :: sync-to-downstream_3.17/100: Console, Changes, Git Data |
|
Build 3.17 :: push-latest-container-to-quay_3.17/88: Console, Changes, Git Data |
|
Build 3.17 :: get-sources-rhpkg-container-build_3.17/110: server : 3.17 :: Build 65956574 : quay.io/devspaces/server-rhel8:3.17-9 |
|
Build 3.17 :: update-digests_3.17/349: Console, Changes, Git Data |
|
Build 3.17 :: server_3.17/6: Upstream sync done; /DS_CI/sync-to-downstream_3.17/100 triggered |
|
Build 3.17 :: operator-bundle_3.17/38: Console, Changes, Git Data |
|
Build 3.17 :: sync-to-downstream_3.17/101: Console, Changes, Git Data |
|
Build 3.17 :: push-latest-container-to-quay_3.17/89: Console, Changes, Git Data |
|
Build 3.17 :: copyIIBsToQuay/2883: Console, Changes, Git Data |
|
Build 3.17 :: sync-to-downstream_3.17/101: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.17/111 triggered; /job/DS_CI/job/dsc_3.17 triggered; |
|
Build 3.17 :: operator-bundle_3.17/38: Upstream sync done; /DS_CI/sync-to-downstream_3.17/101 triggered |
|
Build 3.17 :: dsc_3.17/39: Console, Changes, Git Data |
|
Build 3.17 :: update-digests_3.17/349: Detected new images: rebuild operator-bundle |
|
Build 3.17 :: dsc_3.17/39: 3.17.0-CI |
…ity (#741)
Improve the isPublicRepository() function in the GitlabAuthorizingFileContentProvider class to check the http response status code. The previous way with the urlFetcher does not work because gitlab server returns a content of an html page with credentials input instead of an error.
What does this PR do?
Cherry pick from #741
Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedRelease Notes
Reviewers
Reviewers, please comment how you tested the PR when approving it.