Successfully started workspaces ratio

[skabashnyuk]

What does this PR do?

The idea behind the scene is to provide some metric for end users/admins that will show how successful Che master is able to start workspaces in some particular point of time. This metric should be related to the total number of workspace what was starting in that period of time.

Add Prometheus metrics:

# HELP che_workspace_starting_attempts_total The count of workspaces starting attempts
# TYPE che_workspace_starting_attempts_total counter
che_workspace_starting_attempts_total 4.0
# HELP che_workspace_started_total The count of started workspaces
# TYPE che_workspace_started_total counter
che_workspace_started_total 3.0

And Grafana panel

What issues does this PR fix or reference?

Fixes #12723

Release Notes

n/a

Docs PR

n/a

[sleshchenko]

LGTM

[skabashnyuk]

ci-test

[garagatyi]

Would be very helpful to explain in the PR description not only what is done but actually why it is done. It is not obvious that counters needed for the evaluation of rates. Adding this info into a PR would simplify PR review and you would get less questions and faster reviews. Thanks!

[skabashnyuk]

@metlos you were right with zero division and NaN values. I've changed a bit a concept of a graph.
Now it's two metrics

1. Success - Success/(Success+Fail)
2. Fail - Fail/(Success+Fail)

Also, there are some changes in the graph.

• Values are stacked.
• Nan interpreted as zero.

[che-bot]

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:12852
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

[skabashnyuk]

ci-test

[metlos]

@metlos you were right with zero division and NaN values. I've changed a bit a concept of a graph.
Now it's two metrics

1. Success - Success/(Success+Fail)

2. Fail - Fail/(Success+Fail)

The only question I have is about the new che_workspace_starting_attempts_total. Do I understand it correctly that it should be equal to the Success+Fail in your above description?

[che-bot]

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:12852
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

[ibuziuk]

@skabashnyuk great job!
@fche @l0rd @slemeur probably a great candidate for one of two metrics exposed to statuspage redhat-developer/rh-che#1224

[slemeur]

Are there any documentation planed for that PR?

[skabashnyuk]

ci-test

[skabashnyuk]

@metlos

The only question I have is about the new che_workspace_starting_attempts_total. Do I understand it correctly that it should be equal to the Success+Fail in your above description?

Not exactly. che_workspace_starting_attempts_total=Success+Fail+Starting

@slemeur

Are there any documentation planned for that PR?

I was planning to do that as part of this #12543 issue

[che-bot]

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:12852
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.