Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1690 use correct HTTP status code for "if-equal": skip on equality #1696

Merged
merged 2 commits into from
Jul 21, 2023
Merged

#1690 use correct HTTP status code for "if-equal": skip on equality #1696

merged 2 commits into from
Jul 21, 2023

Conversation

thjaeckle
Copy link
Member

Fixes: #1690

@thjaeckle thjaeckle added the bug label Jul 17, 2023
@thjaeckle thjaeckle added this to the 3.3.5 milestone Jul 17, 2023
@thjaeckle
adjusted method name of exception builder
73fb51c 
* restructured IfEqualPreconditionHeader logic to be more readable
* fixed that an inline policy in a "MergeThing" command would always cause inequality

Signed-off-by: Thomas Jäckle <[email protected]>
@thjaeckle thjaeckle self-assigned this Jul 18, 2023
alstanchev
alstanchev approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@alstanchev alstanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thjaeckle thjaeckle merged commit 1539e35 into master Jul 21, 2023
2 checks passed
@thjaeckle thjaeckle deleted the bugfix/if-equals-wrong-http-status-code branch July 21, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alstanchev alstanchev alstanchev approved these changes

Assignees

@thjaeckle thjaeckle

Labels
bug
Projects
Ditto Planning
Status: Done
Milestone
3.3.5
Development

Successfully merging this pull request may close these issues.

Modification with new if-equal: skip header returns wrong HTTP status code
2 participants
@thjaeckle @alstanchev