Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display attributes in UI in an aceEditor instead of a simple inputfield #1812

Merged
merged 2 commits into from
Nov 25, 2023

Conversation

thjaeckle
Copy link
Member

  • for attributes which were JsonObjects or JsonArrays, displaying them in a single "input" field was very umcomfortable

This PR shows all attributes also in an aceEditor, while still showing the string representation in the attributes table.

@thfries I would appreciate if you could have a look

* for attributes which were JsonObjects or JsonArrays, displaying them in a single "input" field was very umcomfortable
@thjaeckle thjaeckle added the UI Issues related to the Ditto explorer UI label Nov 22, 2023
@thjaeckle thjaeckle added this to the 3.5.0 milestone Nov 22, 2023
@thjaeckle thjaeckle self-assigned this Nov 22, 2023
Copy link
Contributor

@thfries thfries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thjaeckle,

I have two comments. Rest is very cool 👍. Thank you!

ui/modules/things/things.html Outdated Show resolved Hide resolved
ui/modules/things/attributes.ts Show resolved Hide resolved
@thjaeckle thjaeckle merged commit ce3f3ac into master Nov 25, 2023
3 checks passed
@thjaeckle thjaeckle deleted the feature/show-attribute-in-editor branch November 25, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Issues related to the Ditto explorer UI
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants