Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - fix operations new empty logger #1817

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

thfries
Copy link
Contributor

@thfries thfries commented Nov 25, 2023

Hi, please find this PR to fix #1809

@thjaeckle: btw: don't we need an option to delete a logger, too?

@thjaeckle
Copy link
Member

@thfries when I remember correctly, deleting a logger or setting its log level to OFF was problematic.
At least not all off loggers could be queried and displayed, because the logger api Ditto uses would return for log level "off" basically all loggers which don't have a defined log level.
And those are thousands.. 😕

Or did you mean something else?

@thfries
Copy link
Contributor Author

thfries commented Nov 25, 2023

I was testing to create new loggers like "foobar" (which is invalid, too) and was not able to "undo" that operation. In general you can create additional loggers but there is no way to undo.
Log level "OFF" is currently not available in the UI.
May be this is exactly what I mean: if you would set the log level to "OFF" it would disappear from the list? We could show a confirmation modal in this case.

@thjaeckle
Copy link
Member

I was testing to create new loggers like "foobar" (which is invalid, too) and was not able to "undo" that operation. In general you can create additional loggers but there is no way to undo. Log level "OFF" is currently not available in the UI. May be this is exactly what I mean: if you would set the log level to "OFF" it would disappear from the list? We could show a confirmation modal in this case.

Yes, that is a good idea:

  • make "off" configurable as log level
  • show a confirmation that - in order to show/activate the logger again - it must be explicitly added as a new logger again

Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thfries do you also want to address the "off" logger in this PR, or not for now?

@thjaeckle thjaeckle added bug UI Issues related to the Ditto explorer UI labels Nov 27, 2023
@thjaeckle thjaeckle added this to the 3.4.2 milestone Nov 27, 2023
@thjaeckle thjaeckle assigned thjaeckle and thfries and unassigned thjaeckle Nov 27, 2023
@thfries
Copy link
Contributor Author

thfries commented Nov 27, 2023

@thjaeckle, let s make it separately.

@thjaeckle thjaeckle merged commit 8509077 into eclipse-ditto:master Nov 27, 2023
3 checks passed
@thjaeckle thjaeckle modified the milestones: 3.4.2, 3.5.0 Nov 29, 2023
@thfries thfries deleted the ui_fix_services_logging branch October 5, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug UI Issues related to the Ditto explorer UI
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Enhancement Proposal: Addressing Operations Tab UI Issue with Logger Creation and Level Buttons
2 participants