-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI - Add filter for tables #1862
UI - Add filter for tables #1862
Conversation
- introduce jest for unit testing - created new tableFilter web component - upgraded dependencies - fixed error in tsconfig - introduced basic filter to create queries in UI - dropdown entries now can attach data - split adding dropdown entries for single and multiple entries - moved utility methods to utils - added table filter to connection logs - added table filter to incoming thing messages - connection metrix now shows red numbers for failures - removed unused symbol in Things tab Signed-off-by: thfries <[email protected]>
Thanks a lot @thfries |
@thfries I had a look at the added filter
Some other remarks:
And regarding the RQL based filtering:
Do you have an idea for the mentioned remarks? |
Hi @thjaeckle, thanks for your feedback. Highly appreciated.
So I will investigate to those improvements... |
Ditto 3.5 was planned to be released next week. So I would eg not try to cover the rql filtering. |
@thfries If you don't mind, I would like to work on fixing the one point - so that we can get this PR ready to be merged for the Ditto 3.5 release:
I already did that for the other search bar, so should not be a big thing.. |
… fields Signed-off-by: Thomas Jäckle <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this little fix - preventing the browser from suggesting credentials for the input field. And also for the policyId.
From my point of view good to be merged, as we can tackle the other mentioned issues as follow-ups.
Hi @thjaeckle, thank you for stepping in and considering the PR for 3.5! I did not find the time. Happy to have that in and thank you for the fix. |
Hello @thjaeckle,
I again totally messed up the other PR, so please find this new PR for #1818.
Merge conflict should be resolved. Headers to new files added.
As mentioned, if this works well, I would like to extend that to RQL and use it also for Things search.
Any feedback also well come. I expect there can be improvements.
Details on commits:
Resolves: #1818