Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataspace protocol: introduce reasons for termination messages #2729

Open
juliapampus opened this issue Apr 14, 2023 · 4 comments
Open

dataspace protocol: introduce reasons for termination messages #2729

juliapampus opened this issue Apr 14, 2023 · 4 comments
Labels
dataspace-protocol related to the dataspace protocol enhancement New feature or request
Milestone

Comments

@juliapampus
Copy link
Contributor

juliapampus commented Apr 14, 2023

Feature Request

Add a list of termination reasons to TransferTerminationMessage and ContractNegotiationTerminationMessage.

  • new value in TransferTerminationMessage
  • replace String rejectionReason in ContractNegotiationTerminationMessage

Which Areas Would Be Affected?

spi, protocol services

Why Is the Feature Desired?

According to the spec, both messages support an optional list of termination reasons. Those are of type object. The spec doesn't define the schema.

Solution Proposal

Introduce a class that can be extended if needed (e.g., predefined enums like in StoreFailure):

public class ProtocolServiceFailure extends Failure {

    private final String reason;

    ...
}

Add mapping in dsp transformers.

@juliapampus juliapampus added enhancement New feature or request dataspace-protocol related to the dataspace protocol labels Apr 14, 2023
@juliapampus juliapampus changed the title dataspace protocol: introduce terminationReason for termination messages dataspace protocol: introduce reasons for termination messages Apr 14, 2023
@juliapampus
Copy link
Contributor Author

Should be List<Object> reasons for now.

@github-actions
Copy link

github-actions bot commented May 3, 2023

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale Open for x days with no activity label May 3, 2023
@github-actions
Copy link

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 11, 2023
@github-actions
Copy link

This issue was closed because it has been inactive for 7 days since being marked as stale.

@wolf4ood wolf4ood reopened this Oct 24, 2024
@wolf4ood wolf4ood added this to the Backlog milestone Oct 24, 2024
@github-actions github-actions bot added the triage all new issues awaiting classification label Oct 24, 2024
@wolf4ood wolf4ood removed stale Open for x days with no activity triage all new issues awaiting classification labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataspace-protocol related to the dataspace protocol enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants