Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataspace-Protocol: Missing attributes code and reason in TransferTerminationMessage and ContractNegotiationTerminationMessage #2764

Closed
janpmeyer opened this issue Apr 19, 2023 · 2 comments · Fixed by #2771
Closed

Dataspace-Protocol: Missing attributes code and reason in TransferTerminationMessage and ContractNegotiationTerminationMessage #2764

janpmeyer opened this issue Apr 19, 2023 · 2 comments · Fixed by #2771
Labels
dataspace-protocol related to the dataspace protocol enhancement New feature or request
Milestone
Milestone 9

Comments

@janpmeyer
Copy link
Contributor

Feature Request

The request message TransferTerminationMessage misses the attributes code and reason like the spec has.

The request message ContractNegotiationTerminationMessage misses the attribute code like the spec defines.

Which Areas Would Be Affected?

control-plane, dsp-specification

Why Is the Feature Desired?

support the dataspace protocol

Solution Proposal

Add the fields code and reason to the TransferTerminationMessage.

Add the field code to the TransferTerminationMessage.

Also we have to look on the discussion in #2729 and look how the reason attribute should look like in the future.
@janpmeyer janpmeyer added enhancement New feature or request dataspace-protocol related to the dataspace protocol labels Apr 19, 2023
@janpmeyer
Copy link
Contributor Author

@jimmarino @ndr-brt

Any thoughts on this topic, or are you fine with this approach?

@ndr-brt
Copy link
Member

ndr-brt commented Apr 20, 2023

Fine with it, please check also #2729 because it could overlap with this issue

@janpmeyer janpmeyer mentioned this issue Apr 20, 2023
Merged
7 tasks
@juliapampus juliapampus mentioned this issue Apr 24, 2023
Merged
7 tasks
@juliapampus juliapampus added this to the Milestone 9 milestone Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dataspace-protocol related to the dataspace protocol enhancement New feature or request
Projects
None yet
Milestone
Milestone 9
Development

Successfully merging a pull request may close this issue.

feat: dataspace protocol negotiation transformer FraunhoferISST/edc-connector
3 participants
@ndr-brt @juliapampus @janpmeyer