feat: dataspace protocol negotiation API #2709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliapampus
added
enhancement
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2709 +/- ##
=======================================
Coverage 64.77% 64.77%
=======================================
Files 956 956
Lines 19603 19603
Branches 1171 1171
=======================================
Hits 12697 12697
Misses 6453 6453
Partials 453 453
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
juliapampus
changed the title
juliapampus
force-pushed
the
feat/dsp_contract_negotiation
branch
from
71e11db
to
9e914d8
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ava/org.eclipse.edc.protocol.dsp.negotiation.transform/DspNegotiationTransformExtension.java
Fixed
Show fixed
Hide fixed
ndr-brt
reviewed
Apr 19, 2023
...i/src/main/java/org/eclipse/edc/protocol/dsp/negotiation/api/DspNegotiationApiExtension.java
Outdated
Show resolved
Hide resolved
...pi/src/main/java/org/eclipse/edc/protocol/dsp/negotiation/api/controller/NegotiationApi.java
Outdated
Show resolved
Hide resolved
...main/java/org/eclipse/edc/protocol/dsp/negotiation/api/controller/NegotiationController.java
Outdated
Show resolved
Hide resolved
...main/java/org/eclipse/edc/protocol/dsp/negotiation/api/controller/NegotiationController.java
Outdated
Show resolved
Hide resolved
...c.protocol.dsp.negotiation.transform/to/JsonObjectToContractAgreementRequestTransformer.java
Outdated
Show resolved
Hide resolved
juliapampus
force-pushed
the
feat/dsp_contract_negotiation
branch
from
967552b
to
df8f882
Compare
juliapampus
force-pushed
the
feat/dsp_contract_negotiation
branch
from
df8f882
to
3538129
Compare
juliapampus
force-pushed
the
feat/dsp_contract_negotiation
branch
from
3538129
to
f17dace
Compare
juliapampus
force-pushed
the
feat/dsp_contract_negotiation
branch
from
f17dace
to
ad6af77
Compare
juliapampus
requested review from
ronjaquensel
and removed request for
jimmarino
|
I addressed your comments @ndr-brt and added a simplified test, thx @ronjaquensel! |
jimmarino
requested changes
Apr 21, 2023
...n/java/org/eclipse/edc/protocol/dsp/negotiation/api/controller/DspNegotiationController.java
Outdated
Show resolved
Hide resolved
...n/java/org/eclipse/edc/protocol/dsp/negotiation/api/controller/DspNegotiationController.java
Outdated
Show resolved
Hide resolved
...n/java/org/eclipse/edc/protocol/dsp/negotiation/api/controller/DspNegotiationController.java
Outdated
Show resolved
Hide resolved
...n/java/org/eclipse/edc/protocol/dsp/negotiation/api/controller/DspNegotiationController.java
Show resolved
Hide resolved
...n/java/org/eclipse/edc/protocol/dsp/negotiation/api/controller/DspNegotiationController.java
Show resolved
Hide resolved
...src/main/java/org/eclipse/edc/protocol/dsp/negotiation/api/controller/DspNegotiationApi.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/eclipse/edc/protocol/dsp/negotiation/api/controller/DspNegotiationApi.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/eclipse/edc/protocol/dsp/negotiation/api/controller/DspNegotiationApi.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/eclipse/edc/protocol/dsp/negotiation/api/controller/DspNegotiationApi.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/eclipse/edc/protocol/dsp/negotiation/api/controller/DspNegotiationApi.java
Outdated
Show resolved
Hide resolved
ndr-brt
reviewed
Apr 21, 2023
...n/java/org/eclipse/edc/protocol/dsp/negotiation/api/controller/DspNegotiationController.java
Outdated
Show resolved
Hide resolved
...n/java/org/eclipse/edc/protocol/dsp/negotiation/api/controller/DspNegotiationController.java
Show resolved
Hide resolved
...va/org/eclipse/edc/protocol/dsp/negotiation/api/controller/DspNegotiationControllerTest.java
Outdated
Show resolved
Hide resolved
...n/java/org/eclipse/edc/protocol/dsp/negotiation/api/controller/DspNegotiationController.java
Outdated
Show resolved
Hide resolved
juliapampus
force-pushed
the
feat/dsp_contract_negotiation
branch
from
91da032
to
d6eb239
Compare
juliapampus
force-pushed
the
feat/dsp_contract_negotiation
branch
from
d6b41d2
to
8324384
Compare
jimmarino
approved these changes
Apr 24, 2023
ndr-brt
approved these changes
Apr 24, 2023
majadlymhmd
pushed a commit
to FraunhoferISST/edc-connector
that referenced
this pull request
May 10, 2023
* feat(dsp-negotiation): implement api module * feat(dsp-negotiation): implement spi module * feat(dsp-negotiation): add dsp-negotiation-transform * refactor(dsp-negotiation-api): clean up controller implementation * chore(dsp-transform): add TypeUtil * chore(dsp-negotiation-api): implement controller tests * chore(dsp-negotiation-api): extract isOfExpectedType to TypeUtil * chore(dsp-negotiation-api): update openApi documentation * chore(dsp-negotiation-api): remove ContractNegotiationService from controller * refactor(dsp-negotiation-api): remove DspNegotiationApi * refactor(dsp-negotiation-api): move object mapper * refactor(dsp-negotiation-api): replace @MethodSource with @ArgumentsSource in test * refactor(dsp-negotiation-api): move duplicated calls to processMessage * fix: resolve broken imports * fix: resolve conflicts of rebase * fix(dsp): add missing and change wrong annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Implements contract negotiation api.
Why it does that
Support the dataspace protocol specification.
Further notes
Adds dependencies:
:data-protocols:dsp:dsp-negotiation:dsp-negotiation-spi:data-protocols:dsp:dsp-negotiation:dsp-negotiation-transform(classes are contributed with feat: dataspace protocol negotiation transformer #2771)Linked Issue(s)
Relates #2474
Checklist
no-changelog)