Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dataspace-protocol add missing fields to TransferTerminationMessage #2777

Merged
merged 1 commit into from
Apr 20, 2023
Merged

feat: dataspace-protocol add missing fields to TransferTerminationMessage #2777

merged 1 commit into from
Apr 20, 2023

Conversation

janpmeyer
Copy link
Contributor

@janpmeyer janpmeyer commented Apr 20, 2023 •
edited
Loading

What this PR changes/adds

Adds the attribute fields code and reason to TransferTerminationMessage like the spec describes. Also adds the new fields to exisiting Tests.

Why it does that

To align the TransferTerminationMessage with the dataspace-protocol

Further notes

The issue #2764 also defines to add the code attribute to the ContractNegotiationTerminationMessage. This is done in
the PR #2771.

Linked Issue(s)

Relates #2764

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

@janpmeyer janpmeyer temporarily deployed to Azure-dev April 20, 2023 12:23 — with GitHub Actions Inactive
@janpmeyer janpmeyer added dataspace-protocol related to the dataspace protocol enhancement New feature or request labels Apr 20, 2023
@janpmeyer
Copy link
Contributor Author

@ndr-brt

In the TransferProcessManagerImpl you create an TransferTerminationMessage. Mabey you have an idea what code and reason could make sense to use?

Or should it be empty for now. In the spec an code required, but a reason not.

@janpmeyer janpmeyer requested a review from ndr-brt April 20, 2023 13:03
@janpmeyer janpmeyer marked this pull request as ready for review April 20, 2023 13:03
@ndr-brt ndr-brt merged commit 6d3fc9b into eclipse-edc:main Apr 20, 2023
@juliapampus juliapampus mentioned this pull request Apr 24, 2023
Closed
@janpmeyer janpmeyer mentioned this pull request Apr 25, 2023
Closed
majadlymhmd pushed a commit to FraunhoferISST/edc-connector that referenced this pull request May 10, 2023
@janpmeyer @majadlymhmd
feat: dataspace-protocol add missing fields to TransferTerminationMes…
3291e36 
…sage (eclipse-edc#2777)

chore(dsp-transfer-process-transformer): add reason and code fields to TransferTerminationMessage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndr-brt ndr-brt ndr-brt approved these changes

Assignees
No one assigned
Labels
dataspace-protocol related to the dataspace protocol enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janpmeyer @ndr-brt