feat: dataspace protocol negotiation dispatcher

[juliapampus]

What this PR changes/adds

Adds delegates for dsp negotiation messages.

Why it does that

Implement dataspace protocol

Further notes

Adds dependencies:

• :data-protocols:dsp:dsp-negotiation:dsp-negotiation-spi
• :data-protocols:dsp:dsp-negotiation:dsp-negotiation-transform (classes are contributed with feat: dataspace protocol negotiation transformer #2771)

Linked Issue(s)

Relates #2474

Checklist

• added appropriate tests?
• performed checkstyle check locally?
• added/updated copyright headers?
• documented public classes/methods?
• added/updated relevant documentation?
• assigned appropriate label? (exclude from changelog with label no-changelog)
• formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

[jimmarino]

Couldn't some of the boilerplate code around creating a JSON structure, HTTP request and dispatching it be pulled up into an abstract class?

[juliapampus]

Couldn't some of the boilerplate code around creating a JSON structure, HTTP request and dispatching it be pulled up into an abstract class?

Agree. When you are okay with it, I would open an issue for this refactoring. I guess we could also merge this with the transformer delegates and add the abstract class to the dsp-http-core module, as soon as both PRs are merged.

[jimmarino]

I think we should refactor this PR to include the abstract class because it will simplify the code, which contains a lot of duplication. Later we can move the abstract class out in a subsequent PR.

[ndr-brt]

Couldn't some of the boilerplate code around creating a JSON structure, HTTP request and dispatching it be pulled up into an abstract class?

I would prefer a collaborator, its behavior is pretty clear, serialize a RemoteMessage, it could be an interface called RemoteMessageSerializer with the JsonLdRemoteMessageSerializer implementation.

I agree that this should be done in this PR, it won't take much and it will simplify tests a lot

[juliapampus]

PR is rebased. @ronjaquensel will take care of refactoring. The refactored structure will then also be applied to #2760.

[ronjaquensel]

@ndr-brt @jimmarino I refactored the delegates as follows:

• Introcuded JsonLdRemoteMessageSerializer interface and implementation in dsp-http-spi and dsp-http-core respectively (for now, can be moved further up when required). This serializer is now used by the delegates to transform, compact and serialize a message.
• Made DspHttpDispatcherDelegate an abstract class and moved the code for creating the HTTP request there. As this is specific to HTTP dispatchers, I think it makes more sense in the abstract class than as an additional helper class. But as this is just a single method, it should not make the code harder to read/understand.
• Introduced a testFixture for delegates, as pretty much the same code was duplicated between many of the delegate tests. The testFixture itself does not contain @Test annotated methods, but instead provides methods for testing the common behaviour that can be used in the delegate tests. First, I wanted to move the actual tests to the testFixture class, but as the delegate tests use these methods in different combinations (e.g. some parse the response body, others don't), that quickly became rather confusing and unreadable.

[codecov-commenter]

Codecov Report

Patch coverage: 87.23% and project coverage change: +0.48 🎉

Comparison is base (da9d50c) 65.50% compared to head (cb4648d) 65.99%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2780      +/-   ##
==========================================
+ Coverage   65.50%   65.99%   +0.48%     
==========================================
  Files         978      979       +1     
  Lines       19896    19806      -90     
  Branches     1177     1163      -14     
==========================================
+ Hits        13032    13070      +38     
+ Misses       6398     6271     -127     
+ Partials      466      465       -1     

Impacted Files	Coverage Δ
.../dispatcher/DspCatalogHttpDispatcherExtension.java	0.00% <0.00%> (ø)
...eclipse/edc/protocol/dsp/DspHttpCoreExtension.java	0.00% <0.00%> (ø)
...patcher/DspNegotiationHttpDispatcherExtension.java	0.00% <0.00%> (ø)
...r/delegate/ContractRequestMessageHttpDelegate.java	90.00% <90.00%> (ø)
...or/service/catalog/CatalogProtocolServiceImpl.java	100.00% <100.00%> (ø)
.../dsp/catalog/api/controller/CatalogController.java	100.00% <100.00%> (+6.89%)	⬆️
...ispatcher/delegate/CatalogRequestHttpDelegate.java	100.00% <100.00%> (+5.71%)	⬆️
...sonObjectFromCatalogRequestMessageTransformer.java	100.00% <100.00%> (ø)
.../JsonObjectToCatalogRequestMessageTransformer.java	60.00% <100.00%> (-8.43%)	⬇️
...rialization/JsonLdRemoteMessageSerializerImpl.java	100.00% <100.00%> (ø)
... and 4 more

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.