Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dsp): add transformer for JsonObjectToDataAddress #2811

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Apr 26, 2023

What this PR changes/adds

Adds a JsonObjectToDataAddressTransformer plus tests.

Why it does that

DataAddresses must be (JSON-LD)-type-aware, so we need a transformer for it.

Further notes

this PR is needed for #2767

  • I had to (re-)create the CoreConstants.java into the core-spi, because we need access to the EDC_NAMESPACE. This is already done in PR feat(api): create new Asset API #2807, but that is not yet merged.

Linked Issue(s)

Needed for #2767
Needed for #2806

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 76.19% and project coverage change: +0.07 🎉

Comparison is base (e0717bd) 65.87% compared to head (4203745) 65.95%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2811      +/-   ##
==========================================
+ Coverage   65.87%   65.95%   +0.07%     
==========================================
  Files         974      982       +8     
  Lines       19770    19847      +77     
  Branches     1168     1169       +1     
==========================================
+ Hits        13024    13090      +66     
- Misses       6278     6288      +10     
- Partials      468      469       +1     
Impacted Files Coverage Δ
...nsformer/DspTransferProcessTransformExtension.java 0.00% <0.00%> (ø)
.../org/eclipse/edc/spi/types/domain/DataAddress.java 84.84% <25.00%> (ø)
...sformer/to/JsonObjectToDataAddressTransformer.java 92.85% <92.85%> (ø)
...ype/from/JsonObjectFromDataAddressTransformer.java 100.00% <100.00%> (ø)
...ansformer/from/JsonObjectFromAssetTransformer.java 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jimmarino jimmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit if you want to add the constant or not, it's up to you.

@paullatzelsperger paullatzelsperger temporarily deployed to Azure-dev April 26, 2023 11:05 — with GitHub Actions Inactive
@paullatzelsperger paullatzelsperger merged commit 9117d45 into eclipse-edc:main Apr 26, 2023
majadlymhmd pushed a commit to FraunhoferISST/edc-connector that referenced this pull request May 10, 2023
)

* feat(dsp): add transformer for JsonObjectToDataAddress

* pr remarks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core feature dataspace-protocol related to the dataspace protocol enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants