-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dsp): add transformer for JsonObjectToDataAddress #2811
feat(dsp): add transformer for JsonObjectToDataAddress #2811
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2811 +/- ##
==========================================
+ Coverage 65.87% 65.95% +0.07%
==========================================
Files 974 982 +8
Lines 19770 19847 +77
Branches 1168 1169 +1
==========================================
+ Hits 13024 13090 +66
- Misses 6278 6288 +10
- Partials 468 469 +1
... and 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit if you want to add the constant or not, it's up to you.
What this PR changes/adds
Adds a
JsonObjectToDataAddressTransformer
plus tests.Why it does that
DataAddresses must be (JSON-LD)-type-aware, so we need a transformer for it.
Further notes
this PR is needed for #2767
CoreConstants.java
into thecore-spi
, because we need access to theEDC_NAMESPACE
. This is already done in PR feat(api): create new Asset API #2807, but that is not yet merged.Linked Issue(s)
Needed for #2767
Needed for #2806
Checklist
no-changelog
)