feat: add dataAddress, code and reason fields to Transfer-Process-Transformer #2812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janpmeyer
added
enhancement
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2812 +/- ##
==========================================
+ Coverage 65.95% 65.98% +0.02%
==========================================
Files 982 1008 +26
Lines 19847 20384 +537
Branches 1169 1199 +30
==========================================
+ Hits 13090 13450 +360
- Misses 6288 6432 +144
- Partials 469 502 +33
☔ View full report in Codecov by Sentry. |
janpmeyer
force-pushed
the
feat/2806-add_missing_fields_to_dsp-transfer-process-transformer
branch
from
25c4d85
to
6e29d95
Compare
janpmeyer
changed the title
…DataAddressTransformer.java
jimmarino
requested changes
Apr 26, 2023
...ansferprocess/transformer/type/from/JsonObjectFromTransferTerminationMessageTransformer.java
Outdated
Show resolved
Hide resolved
...col/dsp/transferprocess/transformer/type/to/JsonObjectToTransferStartMessageTransformer.java
Outdated
Show resolved
Hide resolved
...p/transferprocess/transformer/type/to/JsonObjectToTransferTerminationMessageTransformer.java
Outdated
Show resolved
Hide resolved
ndr-brt
approved these changes
May 2, 2023
...ocol/dsp/transferprocess/transformer/to/JsonObjectToTransferStartMessageTransformerTest.java
Outdated
Show resolved
Hide resolved
ndr-brt
reviewed
May 4, 2023
...ocol/dsp/transferprocess/transformer/to/JsonObjectToTransferStartMessageTransformerTest.java
Outdated
Show resolved
Hide resolved
...ocol/dsp/transferprocess/transformer/to/JsonObjectToTransferStartMessageTransformerTest.java
Outdated
Show resolved
Hide resolved
...sp/transferprocess/transformer/to/JsonObjectToTransferTerminationMessageTransformerTest.java
Show resolved
Hide resolved
ndr-brt
approved these changes
May 8, 2023
juliapampus
deleted the
feat/2806-add_missing_fields_to_dsp-transfer-process-transformer
branch
majadlymhmd
pushed a commit
to FraunhoferISST/edc-connector
that referenced
this pull request
May 10, 2023
…nsformer (eclipse-edc#2812) * chore(dsp-transfer-process-transform): add code and reason field to transformer * chore(dsp-transfer-process-transform): add data Address to TransferTermination[to|from]Transformer * chore(dsp-transfer-process-transform): fix unit Test Bug * chore(dsp-transfer-process-transform): remove duplicated JsonObjectToDataAddressTransformer.java * chore(dsp-transfer-process-transform): refactor if clauses * chore(dsp-transfer-process-transform): refactor tests * chore(dsp-transfer-process-transform): refactor tests
majadlymhmd
pushed a commit
to FraunhoferISST/edc-connector
that referenced
this pull request
May 10, 2023
…nsformer (eclipse-edc#2812) * chore(dsp-transfer-process-transform): add code and reason field to transformer * chore(dsp-transfer-process-transform): add data Address to TransferTermination[to|from]Transformer * chore(dsp-transfer-process-transform): fix unit Test Bug * chore(dsp-transfer-process-transform): remove duplicated JsonObjectToDataAddressTransformer.java * chore(dsp-transfer-process-transform): refactor if clauses * chore(dsp-transfer-process-transform): refactor tests * chore(dsp-transfer-process-transform): refactor tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Add transformation of DataAddress field to JsonObject[to|from]TransferStartMessageTransformer.
Add transformation of code, reason field to JsonObject[to|from]TransferTermiantionMessagerTransformer.
Why it does that
Support dataspace-protocol.
Further notes
TransferTerminationMessage.Builder needs to add an Nullkcheck for code field, after a error code list exist.
Created Issue #2810.
Linked Issue(s)
Closes #2806
Checklist
no-changelog)