feat: implement Configuration Injection #4617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
force-pushed
the
feat/config_injection
branch
from
0781206
to
3a9b654
Compare
paullatzelsperger
force-pushed
the
feat/config_injection
branch
from
3a9b654
to
39270bc
Compare
paullatzelsperger
force-pushed
the
feat/config_injection
branch
5 times, most recently
from
7dd4805
to
dcf22d2
Compare
paullatzelsperger
force-pushed
the
feat/config_injection
branch
from
dcf22d2
to
a22b2c9
Compare
paullatzelsperger
requested review from
jimmarino and
ndr-brt
as code owners
4 tasks
wolf4ood
approved these changes
Nov 13, 2024
jimmarino
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR implements the configuration injection feature whereby configuration values can be injected in several ways.
To do that, some responsibility was moved from the
DependencyGraphand theInjectionPointScannerinto the concreteInjectionPointimplementations.Why it does that
ease of use
Further notes
Adapting the EDC code base to this new feature will come in a subsequent PR, but just to show how the mechanism works, I used it in the
StsRemoteClientConfigurationExtensionand in theCoreServicesExtension.verified with MVD
Future Work
providing default values for
ValueInjectionPointsandConfigurationInjectionPointsisn't very elegant at the moment. The existingdefaultProvidermechanism should be used, but that'll require some more refactoring. So I'll do this in a subsequent PR to keep this one somewhat focused.in subsequent iterations the
DependencyGraphwill get improved in terms of its public API and error handlingLinked Issue(s)
Contributes to #4610
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.