refactor: deprecate data-plane-public-api-v2 and proxy feature #4823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
requested review from
bscholtes1A,
jimmarino and
paullatzelsperger
as code owners
ndr-brt
force-pushed
the
4791-deprecate-data-plane-public-api
branch
from
b378a4c to
90a87fc
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+88
to
+89
| context.getMonitor().warning("The `data-plane-public-api-v2` has been deprecated, please provide an" + | ||
| "alternative implementation for Http Proxy if needed"); |
Check notice
Code scanning / CodeQL
Missing space in string literal Note
ndr-brt
force-pushed
the
4791-deprecate-data-plane-public-api
branch
from
90a87fc to
f16a821
Compare
jimmarino
approved these changes
Feb 13, 2025
ndr-brt
added a commit
to Think-iT-Labs/edc-connector
that referenced
this pull request
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Deprecates
data-plane-public-api-v2andproxy*attributes inHttpDataAddressWhy it does that
follow decision
Further notes
transfer-data-plane-spi: deleted altogetherWho will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #4791
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.