build(test): use testcontainers for postgresql tests #4831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
force-pushed
the
4761-use-testcontainers-for-e2e-tests
branch
8 times, most recently
from
b539110 to
0ba9201
Compare
ndr-brt
force-pushed
the
4761-use-testcontainers-for-e2e-tests
branch
from
0ba9201 to
4452ada
Compare
ndr-brt
force-pushed
the
4761-use-testcontainers-for-e2e-tests
branch
from
4452ada to
4637a9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Make End2End postgresql test to use testconatiners instead of the shared instance
Why it does that
This will avoid dirty data to affect tests from different classes.
Further notes
PostgresqlEndToEndExtensionthat can be used for e2e tests, whilePostgresqlStoreSetupExtensionwould be still the choice for test stores integrationWho will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #4761
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.