-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix marshaling policy #4844
Fix marshaling policy #4844
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contributors manual, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.
@ChMThiel this PR violates multiple rules in our PR Etiquette:
In addition, you need to sign the ECA. you may think it's a minor issue, but unless you follow proper procedure and respect our rules and guidelines, this PR is going to get closed. |
I'm sorry if i don't meet your expectations. |
please take a look at the document I linked. proper formal procedure is as important as code style. |
FYI the links in the pr-etiquette page: coding style, ./architectural patterns, are dead |
description:
Consider property 'profile' when marshaling a 'Policy'-Object to json.
fixes #4843