refactor: remove data-plane-public-v2 deprecated module from dataplane-base-bom #4845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
added
refactoring
paullatzelsperger
approved these changes
Feb 25, 2025
ndr-brt
force-pushed
the
4824-remove-public-api-bom
branch
2 times, most recently
from
056be5a to
0fadff3
Compare
ndr-brt
force-pushed
the
4824-remove-public-api-bom
branch
from
0fadff3 to
e99be1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Removes the deprecated
data-plane-public-v2from thedataplane-base-bomBREAKING CHANGE: if your runtime is using
dataplane-base-bomand you still need thedata-plane-public-v2module, you need to add it manually as dependency in your build file/pom. Please note that the module is duplicated and it will be removed in the upcoming versions.Why it does that
cleanup
Further notes
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #4824
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.