Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unit tests #152

Merged
merged 2 commits into from
Dec 12, 2023
Merged

fix: unit tests #152

merged 2 commits into from
Dec 12, 2023

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Dec 12, 2023

What this PR changes/adds

Fix unit tests

Why it does that

Briefly state why the change was necessary.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Copy link

github-actions bot commented Dec 12, 2023

Test Results

48 tests  +2   48 ✔️ +8   42s ⏱️ +2s
11 suites +1     0 💤 ±0 
11 files   +1     0  - 6 

Results for commit 115904e. ± Comparison against base commit f21a3ff.

This pull request removes 4 and adds 6 tests. Note that renamed tests count towards both.
org.eclipse.edc.catalog.cache.FederatedCatalogCacheExtensionTest ‑ initialize()
org.eclipse.edc.catalog.cache.FederatedCatalogCacheExtensionTest ‑ initialize_withHealthCheck(ObjectFactory)
org.eclipse.edc.catalog.cache.FederatedCatalogCacheExtensionTest ‑ verifyProvider_cacheNodeAdapterRegistry()
org.eclipse.edc.catalog.cache.FederatedCatalogCacheExtensionTest ‑ verify_successHandler_persistIsCalled()
org.eclipse.edc.catalog.cache.FederatedCatalogCacheExtensionTest ‑ initialize(ServiceExtensionContext)
org.eclipse.edc.catalog.cache.FederatedCatalogCacheExtensionTest ‑ initialize_withHealthCheck(ServiceExtensionContext, ObjectFactory)
org.eclipse.edc.catalog.cache.FederatedCatalogCacheExtensionTest ‑ verifyProvider_cacheNodeAdapterRegistry(ServiceExtensionContext)
org.eclipse.edc.catalog.cache.FederatedCatalogCacheExtensionTest ‑ verify_successHandler_persistIsCalled(ServiceExtensionContext)
org.eclipse.edc.catalog.spi.CacheConfigurationTest ‑ getExecutionPlan_whenLowPeriod()
org.eclipse.edc.catalog.spi.CacheConfigurationTest ‑ getNumCrawlers()

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f21a3ff) 65.43% compared to head (115904e) 65.43%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   65.43%   65.43%           
=======================================
  Files          25       25           
  Lines         434      434           
  Branches       15       15           
=======================================
  Hits          284      284           
  Misses        135      135           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt merged commit 92c403c into main Dec 12, 2023
24 checks passed
@ndr-brt ndr-brt deleted the fix-compilation branch December 12, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants