feat: AttestationDefinition vertical #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmarino
approved these changes
Feb 11, 2025
paullatzelsperger
force-pushed
the
feat/537_attestation_definition_vertical
branch
from
4a8d4fb to
ed80c90
Compare
paullatzelsperger
force-pushed
the
feat/537_attestation_definition_vertical
branch
from
ed80c90 to
ad50ec9
Compare
wolf4ood
approved these changes
Feb 11, 2025
paullatzelsperger
deleted the
feat/537_attestation_definition_vertical
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
this PR implements the
AttestationDefinitionvertical, specifically:AttestationDefinitionServicethat transactionally handles DB access:core:issuerservice:issuerservice-credential-definitiontocore:issuerservice:issuerservice-issuanceto mirror the SPI packageWhy it does that
support the manipulation of attestationdefintions via Admin API
Further notes
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #537
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.