Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix typo pom.xm -> pom.xml #297

Merged
merged 2 commits into from
Jul 17, 2024
Merged

chore: fix typo pom.xm -> pom.xml #297

merged 2 commits into from
Jul 17, 2024

Conversation

chlorochrule
Copy link
Contributor

What this PR changes/adds

fixed a bit of typo

@chlorochrule
Copy link
Contributor Author

TransferEndToEndTest looks to have been added recently 👀 Maybe unstable?

TransferEndToEndTest > transferData() FAILED
java.lang.AssertionError:
Expecting actual not to be null
at org.eclipse.edc.demo.tests.transfer.TransferEndToEndTest.lambda$transferData$0(TransferEndToEndTest.java:75)
https://github.com/eclipse-edc/MinimumViableDataspace/actions/runs/9978143759/job/27574368551?pr=297

@paullatzelsperger
Copy link
Member

paullatzelsperger commented Jul 17, 2024 •
edited
Loading

TransferEndToEndTest looks to have been added recently 👀 Maybe unstable?

yes, the test is fairly new. but nope, the error was introduced by an upstream change. once i have the fix ready, you'll need to rebase.

@chlorochrule
Copy link
Contributor Author

understood, thanks!

@paullatzelsperger
Copy link
Member

@chlorochrule good to rebase

@paullatzelsperger
Copy link
Member

mmh, that test appears to be unstable indeed. not relevant for this PR though, so i'll merge it and address the flaky test in another PR

@paullatzelsperger paullatzelsperger merged commit c51e59e into eclipse-edc:main Jul 17, 2024
5 of 6 checks passed
@chlorochrule
Copy link
Contributor Author

hmm, thank you for merging!

@chlorochrule chlorochrule deleted the fix-pom-xml-typo branch July 17, 2024 17:25
@paullatzelsperger paullatzelsperger mentioned this pull request Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paullatzelsperger paullatzelsperger paullatzelsperger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chlorochrule @paullatzelsperger