chore: sanitize Credentials and export Postman Environments #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
documentation
paullatzelsperger
force-pushed
the
chore/sanitize_credentials_and_names
branch
from
5e88588
to
e4efc33
Compare
paullatzelsperger
changed the title
jimmarino
approved these changes
Jul 19, 2024
paullatzelsperger
force-pushed
the
chore/sanitize_credentials_and_names
branch
from
3ba4e46
to
089519d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Up until now, the credentials that were used were not generic enough, so they were made completely fictitious.
In addition, the Postman Environments are now exported as well - they were not exported before.
Why it does that
Consistency
Further notes
The
JwtSignertest now re-generates all credentials from the template and replaces the token in the resource json. could be useful if the credentials are ever updated again.Linked Issue(s)
Closes #304
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.