Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ih_schema.sql to comply with eclipse-edc/IdentityHub#451 #333

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

ligaz
Copy link
Contributor

@ligaz ligaz commented Sep 12, 2024

What this PR changes/adds

This change adds the missing key_context in keypair_resource that was introduced in eclipse-edc/IdentityHub#451.

Why it does that

Without having this column the services start with an error and does not work as expected:

Exception in thread "main" org.eclipse.edc.spi.EdcException: org.eclipse.edc.spi.persistence.EdcPersistenceException: ERROR: column "key_context" of relation "keypair_resource" does not exist
  Position: 181
	at org.eclipse.edc.boot.system.runtime.BaseRuntime.onError(BaseRuntime.java:143)
	at org.eclipse.edc.boot.system.runtime.BaseRuntime.boot(BaseRuntime.java:106)
	at org.eclipse.edc.boot.system.runtime.BaseRuntime.main(BaseRuntime.java:77)
Caused by: org.eclipse.edc.spi.persistence.EdcPersistenceException: ERROR: column "key_context" of relation "keypair_resource" does not exist
  Position: 181
	at org.eclipse.edc.sql.SqlQueryExecutor.execute(SqlQueryExecutor.java:59)
	at org.eclipse.edc.identityhub.store.sql.keypair.SqlKeyPairResourceStore.lambda$create$0(SqlKeyPairResourceStore.java:57)

(full stack trace omitted)

Further notes

I'm not sure how such breaking changes should be propagated to downstream consumers like this sample repo. Maybe the versions of the IdentityHub (and other dependencies) should be pinned.

@paullatzelsperger
Copy link
Member

this is a temporary fix at best. IH and other components now come with a SqlSchemaBootstrapper that automatically creates the DB schema. Please sign the ECA so we can run, review and ultimately merge your PR

@ligaz
Copy link
Contributor Author

ligaz commented Sep 12, 2024

this is a temporary fix at best. IH and other components now come with a SqlSchemaBootstrapper that automatically creates the DB schema. Please sign the ECA so we can run, review and ultimately merge your PR

Thanks for your clarifications. I just signed the ECA.

@ligaz ligaz changed the title Fix ih_schema.sql to comply with eclipse-edc/IdentityHub#451 fix: ih_schema.sql to comply with eclipse-edc/IdentityHub#451 Sep 12, 2024
@ligaz ligaz changed the title fix: ih_schema.sql to comply with eclipse-edc/IdentityHub#451 fix:ih_schema.sql to comply with eclipse-edc/IdentityHub#451 Sep 12, 2024
@ligaz ligaz changed the title fix:ih_schema.sql to comply with eclipse-edc/IdentityHub#451 fix: ih_schema.sql to comply with eclipse-edc/IdentityHub#451 Sep 12, 2024
@paullatzelsperger paullatzelsperger merged commit 00167f2 into eclipse-edc:main Sep 13, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants