feat: extract response ids in postman collection #352
Conversation
nikschul
changed the title
nikschul
changed the title
There was a problem hiding this comment.
LGTM, but could you add the CI workflow as discussed in the issue? Please also update the documentation where applicable.
|
also, you should rebase onto |
adding a postman post-request script to add the policy-id of "asset-1" as a postman environment variable of request "Get Cached Catalogs" and reusing it in "Initiate Negotiation".
…e for scripts is <=200 and <300
nikschul
force-pushed
the
feature/350-extract_response_ids_in_postman_collection
branch
from
9e2ce57
to
54d808c
Compare
nikschul
force-pushed
the
feature/350-extract_response_ids_in_postman_collection
branch
from
8ec1179
to
9ae59ff
Compare
| @@ -48,6 +48,9 @@ jobs: | |||
| - name: "Setup Kubectl" | |||
| uses: azure/setup-kubectl@v4 | |||
|
|
|||
| - name: "Setup Terraform" | |||
There was a problem hiding this comment.
why is this necessary?
There was a problem hiding this comment.
see comment on the main thread
| with: | ||
| node-version: 18 | ||
|
|
||
| - name: "Install Newman" |
There was a problem hiding this comment.
can newman be directly used and does not have to be installed first?
There was a problem hiding this comment.
i think so. I had to merge the PR now, because I needed the terraform thing in another fix. I'll take care of that
|
@paullatzelsperger I've added some tests for the collection which are executed in a new GitHub action workflow "newman_test". Also I had to add an additional terraform setup step in all workflow scrips, as the workflows were failing this morning with "terraform: command not found". I hope this is ok and does not break anything else. |
|
Here is one example of a failing test run, even though I did not change anything regarding this test: https://github.com/eclipse-edc/MinimumViableDataspace/actions/runs/11252232440/job/31284932435 |
huh? that is .... very interesting. stumbled across the same thing too. |
What this PR changes/adds
The functionality to carry over variables from previous responses to following request if applicable. This should make it easier for the user to execute the chain of requests necessary to download data from the other dataspace.
Why it does that
Postman pre- and post-request scripts were added to accomplish this behavior. Also a pre-request check for the respective requests is added to make sure the variables carried over are defined before executing the request
Further notes
Linked Issue(s)
Closes #351