feat: add config injection annotations #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
documentation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.
ndr-brt
reviewed
Nov 8, 2024
4 tasks
ndr-brt
approved these changes
Nov 8, 2024
jimmarino
approved these changes
Nov 8, 2024
runtime-metamodel/src/main/java/org/eclipse/edc/runtime/metamodel/annotation/Configuration.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jim Marino <[email protected]>
paullatzelsperger
deleted the
feat/add_configuration_injection_annotations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This pr introduces two new annotations that are needed for configuration injection, and it updates the
@Settingannotation.Why it does that
preparatory work for eclipse-edc/Connector#4610
Further notes
@Settingin lieu of@Configuration, but that would have made code paths in theautodocprocessor more complicated and hard to understandLinked Issue(s)
Contributes to eclipse-edc/Connector#4610
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.