feat: allow endpoint overrides in AwsSecretsManagerVault #485
+25
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
AwsSecretsManagerVaultExtension
do not allow to override AWS endpoint. However,S3CoreExtension
allows it. So, I implements endpoint overrides inAwsSecretsManagerVault
usingedc.aws.endpoint.override
the same param ofS3CoreExtension
.Why it does that
For AWS-compatible services like localstack.