Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow endpoint overrides in AwsSecretsManagerVault #485

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chlorochrule
Copy link

What this PR changes/adds

AwsSecretsManagerVaultExtension do not allow to override AWS endpoint. However, S3CoreExtension allows it. So, I implements endpoint overrides in AwsSecretsManagerVault using edc.aws.endpoint.override the same param of S3CoreExtension.

Why it does that

For AWS-compatible services like localstack.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.

@paullatzelsperger
Copy link
Member

@chlorochrule do NOT submit surprise PRs.
As per our PR Etiquette, a discussion or an issue must be created beforehand, to outline requirements, motivation and a technical approach for the work.

Committers will then triage the issue and approve it for implementation by removing the triage label. Once that is done you are good to go.

@chlorochrule
Copy link
Author

@paullatzelsperger I apologize for the breaking etiquette, and thank you for pointing that out! I created a ticket #486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants