New copy-file goal #204
Merged
New copy-file goal #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzygielo
reviewed
Jun 10, 2024
OndroMih
force-pushed
the
ondromih-copy-file-mojo
branch
from
0e11095
to
a3bc6f9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
OndroMih
force-pushed
the
ondromih-copy-file-mojo
branch
from
a3bc6f9
to
298e886
Compare
|
Hi, @pzygielo , I added new lines in commit messages. Can you please review again? |
pzygielo
reviewed
Jun 20, 2024
This comment was marked as resolved.
This comment was marked as resolved.
To copy files or the main artifact to a new location.
To copy files or the main artifact to a new location.
Fix copyright headers. Overwrite file if exists.
Skip property to allow skipping execution
Require destFile if skip=false
Update javadoc for the copy-file goal
OndroMih
force-pushed
the
ondromih-copy-file-mojo
branch
from
298e886
to
1dbe3f1
Compare
|
@pzygielo, I removed all changes related to the |
Use streamLogsOnFailures on invoker to log maven output if a test fails
pzygielo
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
- I'd like to know the outcome of Dev profile to update modules without building the whole GlassFish distribution glassfish#24985 - that this goal is really needed here.
|
This goal is useful by itself, even without eclipse-ee4j/glassfish#24985. I use it already, built from sources. With eclipse-ee4j/glassfish#24985, it would be just easier to use with GlassFish, with less custom configuration in settings.xml and IDE or CLI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To copy files or the main artifact to a new location.
Example usage in
ittests.I intend to use this in a new GlassFish "dev" profile that will automatically copy built modules to the GlassFish distribution, which will apply the code changes without building the whole GlassFish.