This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 68
New (correct) version of the "Figure 1 9". #281
Open
DmitriGit
wants to merge
5
commits into
eclipse-ee4j:master
Choose a base branch
from
DmitriGit:figure_1_9
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es': 'ActionSource' is not deprecated, so phrase about deprecation is removed. Signed-off-by: Dmitri Cherkas <[email protected]>
…es': improve readability proposal. Signed-off-by: Dmitri Cherkas <[email protected]>
Signed-off-by: Dmitri Cherkas <[email protected]>
Signed-off-by: Dmitri Cherkas <[email protected]>
Signed-off-by: Dmitri Cherkas <[email protected]>
dmatej
approved these changes
Jan 27, 2023
arjantijms
approved these changes
Jan 30, 2023
ivargrimstad
approved these changes
Jan 30, 2023
This was referenced Jan 30, 2023
I don't understand 48ef63c. This appears to be a unrelated change which destroys the original alphabetic ordering. Where's the ticket which discusses the new ordering? I don't remember seeing this. The change 6e920b0 is fine but I don't understand why this is in the same PR which intends to update the images. |
Ok. Can I attach 2 images with explanation comparision to this email ?
On Wednesday, May 31, 2023 at 03:36:28 PM GMT+2, Bauke Scholtz ***@***.***> wrote:
I don't understand 48ef63c
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
I've sent you email with explanation.
On Wednesday, May 31, 2023 at 03:36:28 PM GMT+2, Bauke Scholtz ***@***.***> wrote:
I don't understand 48ef63c
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this is a new (correct) version of the "Figure 1-9" aligned with Jakarta EE Platform Specification version and names of Jakarta EE Specifications.
Thank you,
Dmitri.