Skip to content

Commit

Permalink
[Build] Assume new equinox.binaries repo name by default in scripts
Browse files Browse the repository at this point in the history
Because the repository containing the Equinox binaries is now named
'eclipse-equinox/equinox.binaries' its folder is, by default, named
'equinox.binaries' after cloning it.
In order to simplify contributions that name should be assumed by
default.

Accordingly rename the property 'rt.equinox.binaries.loc' used in the
build to 'equinox.binaries.loc'.
  • Loading branch information
HannesWell committed Jun 13, 2024
1 parent 313092c commit 70ee8f5
Show file tree
Hide file tree
Showing 9 changed files with 17 additions and 17 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ jobs:
- name: checkout equinox.binaries
uses: actions/checkout@v4
with:
fetch-depth: 1 # only shallow here, we don't have jgit timestamps
repository: eclipse-equinox/equinox.binaries
path: rt.equinox.binaries
fetch-depth: 1 # only shallow here, we don't have jgit timestamps
repository: eclipse-equinox/equinox.binaries
path: equinox.binaries
- name: Set up JDK 17
uses: actions/setup-java@v4
with:
Expand All @@ -54,7 +54,7 @@ jobs:
- name: Build with Maven
uses: coactions/setup-xvfb@v1
env:
EQUINOX_BINARIES_LOC: ${{ github.workspace }}/rt.equinox.binaries
EQUINOX_BINARIES_LOC: ${{ github.workspace }}/equinox.binaries
with:
working-directory: equinox
run: >-
Expand All @@ -65,16 +65,16 @@ jobs:
-Dcompare-version-with-baselines.skip=false
-Dmaven.test.failure.ignore=true
-Dnative=${{ matrix.config.ws }}.${{ matrix.config.os }}.x86_64
-Drt.equinox.binaries.loc=${{ github.workspace }}/rt.equinox.binaries
-Dequinox.binaries.loc=${{ github.workspace }}/equinox.binaries
clean verify
- name: Upload native artifacts
uses: actions/upload-artifact@v4
if: success()
with:
name: ${{ matrix.config.name }} launcher artifacts
path: |
rt.equinox.binaries/org.eclipse.equinox.executable/bin/${{ matrix.config.ws }}/${{ matrix.config.os }}/x86_64/**/eclipse*
rt.equinox.binaries/org.eclipse.equinox.launcher.${{ matrix.config.ws }}.${{ matrix.config.os }}.x86_64/eclipse_*.${{ matrix.config.native-extension }}
equinox.binaries/org.eclipse.equinox.executable/bin/${{ matrix.config.ws }}/${{ matrix.config.os }}/x86_64/**/eclipse*
equinox.binaries/org.eclipse.equinox.launcher.${{ matrix.config.ws }}.${{ matrix.config.os }}.x86_64/eclipse_*.${{ matrix.config.native-extension }}
if-no-files-found: error
- name: Upload ${{ matrix.config.name }} Test Results
uses: actions/upload-artifact@v4
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
with:
fetch-depth: 1 # only shallow here, we don't have jgit timestamps
repository: eclipse-equinox/equinox.binaries
path: rt.equinox.binaries
path: equinox.binaries
# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v3
Expand Down Expand Up @@ -69,7 +69,7 @@ jobs:
-Papi-check
-Dcompare-version-with-baselines.skip=false
-Dmaven.test.failure.ignore=true
-Drt.equinox.binaries.loc=${{ github.workspace }}/rt.equinox.binaries
-Dequinox.binaries.loc=${{ github.workspace }}/equinox.binaries
-DskipTests=true
clean verify
Expand Down
2 changes: 1 addition & 1 deletion Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ pipeline {
sh '''
mvn clean verify --batch-mode --fail-at-end -Dmaven.repo.local=$WORKSPACE/.m2/repository \
-Pbree-libs -Papi-check -Pjavadoc\
-Drt.equinox.binaries.loc=$WORKSPACE/equinox.binaries
-Dequinox.binaries.loc=$WORKSPACE/equinox.binaries
'''
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ PROGRAM_OUTPUT="$programOutput"
DEFAULT_OS="$defaultOS"
DEFAULT_WS="$defaultWS"
DEPLOYMENT_TARGET=11.0
if [ "$BINARIES_DIR" = "" ]; then BINARIES_DIR="../../../../../rt.equinox.binaries"; fi
if [ "$BINARIES_DIR" = "" ]; then BINARIES_DIR="../../../../../equinox.binaries"; fi

if [ "$defaultOSArch" == "arm64" ] || [ "$defaultOSArch" == "aarch64" ]
then
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ programOutput="eclipse"
defaultOS=""
defaultOSArch=""
defaultWS="gtk"
if [ "$BINARIES_DIR" = "" ]; then BINARIES_DIR="../../../../../rt.equinox.binaries"; fi
if [ "$BINARIES_DIR" = "" ]; then BINARIES_DIR="../../../../../equinox.binaries"; fi
defaultJava=DEFAULT_JAVA_JNI
defaultJavaHome=""
javaHome=""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ set DEFAULT_OS=%defaultOS%
set DEFAULT_OS_ARCH=%defaultOSArch%
set DEFAULT_WS=%defaultWS%
set JAVA_HOME=%javaHome%
IF "%BINARIES_DIR%"=="" set "BINARIES_DIR=..\..\..\..\..\rt.equinox.binaries"
IF "%BINARIES_DIR%"=="" set "BINARIES_DIR=..\..\..\..\..\equinox.binaries"
IF "%EXE_OUTPUT_DIR%"=="" set "EXE_OUTPUT_DIR=%BINARIES_DIR%\org.eclipse.equinox.executable\bin\%defaultWS%\%defaultOS%\%defaultOSArch%"
IF "%LIB_OUTPUT_DIR%"=="" set "LIB_OUTPUT_DIR=%BINARIES_DIR%\org.eclipse.equinox.launcher.%defaultWS%.%defaultOS%.%defaultOSArch%"

Expand Down
2 changes: 1 addition & 1 deletion features/org.eclipse.equinox.executable.feature/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
them -->
<echo message="Copy eclipse binaries to launcher binaries" level="info"/>
<copy todir="bin" verbose="true" includeEmptyDirs="false" failonerror="true">
<fileset dir="${rt.equinox.binaries.loc}/org.eclipse.equinox.executable/bin/">
<fileset dir="${equinox.binaries.loc}/org.eclipse.equinox.executable/bin/">
<include name="cocoa/macosx/x86_64/**/*"/>
<include name="cocoa/macosx/aarch64/**/*"/>
<include name="gtk/linux/ppc64le/**/*"/>
Expand Down
2 changes: 1 addition & 1 deletion launcher-binary-parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
<configuration>
<additionalFileSets>
<fileSet>
<directory>${rt.equinox.binaries.loc}/${project.artifactId}</directory>
<directory>${equinox.binaries.loc}/${project.artifactId}</directory>
<includes>
<include>*.so</include>
<include>*.dll</include>
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@

<properties>
<tycho.scmUrl>scm:git:https://github.com/eclipse-equinox/equinox.git</tycho.scmUrl>
<!-- location of rt.equinox.binaries project -->
<!-- location of equinox.binaries project -->
<!-- required by: org.eclipse.equinox.feature:org.eclipse.equinox.executable -->
<!-- required by: org.eclipse.equinox.framework:launcher-binary-parent -->
<rt.equinox.binaries.loc>../../../rt.equinox.binaries</rt.equinox.binaries.loc>
<equinox.binaries.loc>../../../equinox.binaries</equinox.binaries.loc>
<target-platform.optionalDependencies>require</target-platform.optionalDependencies>
</properties>

Expand Down

0 comments on commit 70ee8f5

Please sign in to comment.