Apply project settings o.e.osgi #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Torbjorn-Svensson
commented
Oct 1, 2023
•
Torbjorn-Svensson
commented
- Convert to LF and ensure LF at EOF:
- Removed executable flag on files:
- Format java files:
Torbjorn-Svensson
force-pushed
the
pr/cleanup-o.e.osgi
branch
from
f6abb1f
to
7048ec6
Compare
Torbjorn-Svensson
force-pushed
the
pr/cleanup-o.e.osgi
branch
3 times, most recently
from
384d70d
to
83adc6d
Compare
|
Updated PR in accordance with #324 (comment). |
Torbjorn-Svensson
force-pushed
the
pr/cleanup-o.e.osgi
branch
from
83adc6d
to
a285479
Compare
|
I'm leaving this one for @tjwatson to decide. |
|
Correct me if I am wrong. This isn't urgent to the current release. I will hold off until 2024-03 when the dev branch opens up for the next release. |
|
No, it's not urgent. |
|
@Torbjorn-Svensson can you fix the conflicts? |
Torbjorn-Svensson
force-pushed
the
pr/cleanup-o.e.osgi
branch
from
a285479
to
ba6e0a9
Compare
Branch rebased on 9658936 |
Torbjorn-Svensson
force-pushed
the
pr/cleanup-o.e.osgi
branch
from
ba6e0a9
to
0943d9b
Compare
|
Rebased PR on 1d9eb47. |
Torbjorn-Svensson
force-pushed
the
pr/cleanup-o.e.osgi
branch
from
0943d9b
to
423b9f9
Compare
|
Rebased PR on b297e05 |
Torbjorn-Svensson
force-pushed
the
pr/cleanup-o.e.osgi
branch
from
423b9f9
to
eae67a0
Compare
This was achieved by running: find . -type f -print0 | \ xargs -r0 perl -le 'for (@argv) { print if -f && -T }' | \ xargs -rd'\n' dos2unix -e && \ git checkout src/org/osgi felix Signed-off-by: Torbjörn SVENSSON <[email protected]>
This was achieved by running: find . -type f -executable -print0 | \ xargs -r0 chmod 644 Signed-off-by: Torbjörn SVENSSON <[email protected]>
This was achieved by running: eclipse -consolelog -nosplash -application org.eclipse.jdt.core.JavaCodeFormatter \ -config .settings/org.eclipse.jdt.core.prefs . -data `mktemp -d` && \ git checkout osgi/src/org/osgi felix Signed-off-by: Torbjörn SVENSSON <[email protected]>
Torbjorn-Svensson
force-pushed
the
pr/cleanup-o.e.osgi
branch
from
eae67a0
to
b3e95db
Compare
|
Thanks @Torbjorn-Svensson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.