Apply project settings to o.e.equinox.security.UI #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Torbjorn-Svensson
commented
Oct 1, 2023
Torbjorn-Svensson
commented
- Convert to LF and ensure LF at EOF:
- Format java files:
akurtakov
reviewed
Oct 12, 2023
...se.equinox.security.ui/src/org/eclipse/equinox/internal/security/ui/storage/TabContents.java
Outdated
Show resolved
Hide resolved
This was achieved by running: find . -type f -print0 | \ xargs -r0 perl -le 'for (@argv) { print if -f && -T }' | \ xargs -rd'\n' dos2unix -e Signed-off-by: Torbjörn SVENSSON <[email protected]>
Signed-off-by: Torbjörn SVENSSON <[email protected]>
This was achieved by running: eclipse -consolelog -nosplash -application org.eclipse.jdt.core.JavaCodeFormatter \ -config .settings/org.eclipse.jdt.core.prefs . -data `mktemp -d` Signed-off-by: Torbjörn SVENSSON <[email protected]>
Torbjorn-Svensson
force-pushed
the
pr/cleanup-o.e.equinox.security.ui
branch
from
eac4363
to
f1bd6a4
Compare
akurtakov
approved these changes
Oct 12, 2023
|
@akurtakov Are the build error (API check failed) a real error or due to some tycho/maven update? I think this pr did not have any API problems before the force-push today. |
|
Probably related to eclipse-platform/eclipse.platform.releng.aggregator#1437 |
|
I'll replay the build to see if we can get some more details. |
See discussion on eclipse-pde/eclipse.pde#782 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.