Remove obsolete PreferencesService.get/setDefaultDefaultLookupOrder() #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
force-pushed
the
preferenceService-remove-obsolete-methods
branch
2 times, most recently
from
7b582c9
to
6c55a2e
Compare
These methods grant to much access to the default lookup order and the internal usage in the org.eclipse.core.internal.resources.Workspace has been migrated to the more specific prependScopeToDefaultDefaultLookupOrder() method introduced before.
HannesWell
force-pushed
the
preferenceService-remove-obsolete-methods
branch
from
6c55a2e
to
5c1dc6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods grant to much access to the default lookup order and the internal usage in the
org.eclipse.core.internal.resources.Workspacehas been migrated to the more specificprependScopeToDefaultDefaultLookupOrder()method introduced before.This can be applied once eclipse-platform/eclipse.platform#972 is merged.