Continue without setting TCCL #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See eclipse-equinox#303 why setting TCCL can fail in a regular JDK without SecurityManager. Therefore catch and continue without setting a TCCL.
When this method is called from within a fork-join pool it's impossible to set a TCCL. The JVM will always throw a SecurityException. Therefor we catch it a continue without setting one.
|
@tjwatson Any guidance/requirements for unit testing this? |
tjwatson
requested changes
Apr 16, 2024
...es/org.eclipse.osgi/container/src/org/eclipse/osgi/internal/framework/BundleContextImpl.java
Outdated
Show resolved
Hide resolved
...eclipse.osgi/container/src/org/eclipse/osgi/internal/framework/XMLParsingServiceFactory.java
Outdated
Show resolved
Hide resolved
guw
commented
Apr 16, 2024
...es/org.eclipse.osgi/container/src/org/eclipse/osgi/internal/framework/BundleContextImpl.java
Outdated
Show resolved
Hide resolved
guw
commented
Apr 16, 2024
...eclipse.osgi/container/src/org/eclipse/osgi/internal/framework/XMLParsingServiceFactory.java
Outdated
Show resolved
Hide resolved
tjwatson
approved these changes
Apr 16, 2024
|
Thanks Gunner on turning around a fix and addressing the review! I apologize for the slow response to your PR. It is merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When called from within a fork-join pool, setting the TCCL is not permitted. Therefore catch and continue without setting a TCCL.
Fixes #303.