Unify Configuration- and InstancePreferences into common super-class #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
force-pushed
the
unify-singleton-preference-scops
branch
from
6678466
to
232b1ef
Compare
|
Is anybody interested in reviewing this? |
|
It looks generally fine. |
laeubi
force-pushed
the
unify-singleton-preference-scops
branch
from
232b1ef
to
1f14c08
Compare
HannesWell
force-pushed
the
unify-singleton-preference-scops
branch
from
1f14c08
to
e6d7f9a
Compare
|
Thank you Ed. I just added a few more braces and made fields final where possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids code duplication, which would be increased when similar 'singleton' scopes are implemented like in #446.