Remove now unnecessary calls to String.intern() in PreferencesService #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
force-pushed
the
remove-unncessary-intern
branch
from
92a247f
to
e6f49c6
Compare
The preference keys on which String.intern() is called are already interned when they are put into the EclipsePreferences object since eclipse-equinox#33
HannesWell
force-pushed
the
remove-unncessary-intern
branch
from
e6f49c6
to
b8b93ac
Compare
HannesWell
commented
Dec 23, 2023
Comment on lines
+147
to
+151
| if (!propsToRemove.isEmpty() && !(globalNode instanceof EclipsePreferences)) { | ||
| // intern strings we import because some people in their property change | ||
| // listeners use identity instead of equals. See bug 20193 and 20534. | ||
| propsToRemove.replaceAll(String::intern); | ||
| } |
There was a problem hiding this comment.
The elements in the keys array above are obtained from an ExportedPreferences, which is a subclass of EclipsePreference and therefore has its keys already interned (unless somebody extends this internl class and changes the method to store elements, but those that do that should take care of interning themself).
On the other hand globalNode is just a IEclipsePreferences node from the tree and because Clients may implement this interface, it can be an arbitrary implementation. Therefore interning propsToRemove can only be skipped if the node is of a EclipsePreferences subclass.
In general I would call the listeners that rely on string identity comparison badly implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preference keys on which
String.intern()is called are already interned when they are put into the EclipsePreferences object since #33.Not calling intern again avoids the overhead of it.