Proper exception in PreferencesService#setDefaultLookupOrder() #464 #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Thank you @HeikoKlare for fixing this regression. The change looks good and reasonable.
I just have one tiny nit-pick.
...clipse.equinox.preferences/src/org/eclipse/core/internal/preferences/PreferencesService.java
Outdated
Show resolved
Hide resolved
…e-equinox#464 PreferencesService#setDefaultLookupOrder(String, String, String[]) has recently been changed to now throwing a NullPointerException instead of an IllegalArgumentException in case of any of its order arguments being null. This is incompatible with the API documentation in IPreferencesService. This change restores the existing behavior of throwing an IllegalArgumentException in the mentioned case. Fixes eclipse-equinox#464
|
Thanks Heiko! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PreferencesService#setDefaultLookupOrder(String, String, String[])has recently been changed to now throwing aNullPointerExceptioninstead of anIllegalArgumentExceptionin case of any of its order arguments beingnull. This is incompatible with the API documentation inIPreferencesService.This change restores the existing behavior of throwing an
IllegalArgumentExceptionin the mentioned case.Fixes #464