Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a command to export the module database into a file #468

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Jan 9, 2024

Currently if one has a problematic resolver state it is very hard to provide a reproducing test case for analysis.

This adds a new command exportFrameworkState that allows to export the module database (optional with its wiring state) into a file that later can be loaded for example in a test case to analyze it further.

@laeubi laeubi requested a review from tjwatson January 9, 2024 10:01
Copy link

github-actions bot commented Jan 9, 2024

Test Results

   27 files  ±0     27 suites  ±0   11m 3s ⏱️ -36s
2 170 tests ±0  2 124 ✅ ±0  46 💤 ±0  0 ❌ ±0 
2 228 runs  ±0  2 182 ✅ ±0  46 💤 ±0  0 ❌ ±0 

Results for commit 7c8526e. ± Comparison against base commit d393f75.

♻️ This comment has been updated with latest results.

@laeubi
Copy link
Member Author

laeubi commented Jan 23, 2024

@tjwatson any concerns here?

@laeubi
Copy link
Member Author

laeubi commented Feb 5, 2024

As no concerns a raised I assume this to be ready to be merged as soon as build finished.

@tjwatson
Copy link
Contributor

tjwatson commented Feb 5, 2024

As no concerns a raised I assume this to be ready to be merged as soon as build finished.

I need to take a quick look now.

Currently if one has a problematic resolver state it is very hard to
provide a reproducing test case for analysis.

This adds a new command exportFrameworkState that allows to export the
module database (optional with its wiring state) into a file that later
can be loaded for example in a test case to analyze it further.
Copy link
Contributor

@tjwatson tjwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the package and bundle version associated with this change have already had their package versions increased appropriately for this release. LGTM

@laeubi laeubi merged commit f264415 into eclipse-equinox:master Feb 5, 2024
24 of 26 checks passed
@laeubi
Copy link
Member Author

laeubi commented Feb 5, 2024

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants