Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump of launcher fragments #475

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

akurtakov
Copy link
Member

This rendered the build unstable - fail with comparator errors. It comes due to natives rebuild for
#474 .

This rendered the build unstable - fail with comparator errors.
It comes due to natives rebuild for
eclipse-equinox#474 .
@akurtakov
Copy link
Member Author

Also reported at https://download.eclipse.org/eclipse/downloads/drops4/I20240112-0200/buildlogs/reporeports/reports/versionChecks.html .
Once this one is in it would be best validated via eclipse-platform/eclipse.platform.releng.aggregator#1711 which failed with this error.
I believe it's high time to change the I-build to fail on missing version bump immediately instead of having to wait for hours to figure smth like that - see the PR failed at 20 mins due to that error.
@merks @iloveeclipse @laeubi wdyt about ^?

Copy link

Test Results

   25 files  +   25     25 suites  +25   11m 29s ⏱️ + 11m 29s
2 156 tests +2 156  2 111 ✅ +2 111  45 💤 +45  0 ❌ ±0 
2 200 runs  +2 200  2 155 ✅ +2 155  45 💤 +45  0 ❌ ±0 

Results for commit 4d2f5b8. ± Comparison against base commit 14ba167.

@akurtakov akurtakov merged commit f91fe7c into eclipse-equinox:master Jan 12, 2024
23 of 24 checks passed
@iloveeclipse
Copy link
Member

I believe it's high time to change the I-build to fail on missing version bump immediately instead of having to wait for hours to figure smth like that - see the PR failed at 20 mins due to that error.

Agree. But better if we would not need to detect missing version bumps in fragments by catching this at equinox already. So why don't we fail in equinox?

@laeubi
Copy link
Member

laeubi commented Jan 12, 2024

Rebuilding launchers is a separate job (that might can fail not sure) so you won't see any errors unless you build equinox after rebuilding launchers, in that case it would probably be already reported...

@akurtakov
Copy link
Member Author

I believe it's high time to change the I-build to fail on missing version bump immediately instead of having to wait for hours to figure smth like that - see the PR failed at 20 mins due to that error.

Agree. But better if we would not need to detect missing version bumps in fragments by catching this at equinox already. So why don't we fail in equinox?

Because the build is done by bot which commits in two repos and if the binaries repo (which contains only dll/so files) gets new content we can't afford to not update the buildable repo. One it was in the maser build of equinox failed https://ci.eclipse.org/equinox/job/equinox/job/master/294/ .

If/when equinox.binaries repo is gone maybe it could be made to open a PR rather than push directly so it's detected.
There is also the question whether equinox verification job (and all others actually) should send mails to respective dev lists on master build failures as this would give us one more change to catch such issue earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants