-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary casts #647
Conversation
Version bump needed: |
Sorry, I can't find that test so I cannot test if this failure could possibly be related. |
It is not related. |
thanks. |
I think it’s best for there to be one commit not 3. I think I can do that with squash and merge button, but I’ve not tried that before. |
That worked okay. |
There's a first time for everything :) (On other occasions people wanted to have version bumps separate from code changes, but perhaps that's only relevant in projects with BETA_JAVAXY branches). |
Yes sometimes people want that. I think to make revert easier. But we don’t expect to revert this and the preceding state would never build successfully. 😬 |
And probably two separate version bump commits never make sense. 😱 Personally I generally amend and force push until I’m done. No one has complained so far. 😜 |
Yes, that was the reason for the policy. Generally, it caused problems if we reverted and one I-Build to the next we had a version decrease. The other issue was if other changes happened after then the version decrease would become an issue also. But a straight revert in this project seems pretty rare vs. a new PR that fixes the issue on top of the existing changes. |
Nothing I commit ever needs to be reverted. 👼 😜 |
When eclipse-jdt/eclipse.jdt.core#2471 is merged, ecj will signal more casts as unnecessary.
With this PR I suggest to remove affected casts before new warnings will show up in the build.