Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ProgressMonitor usage in ProvisioningContext #313

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

HannesWell
Copy link
Member

  • Use SubMonitor.split() over newChild()
  • Remove explicit checks for cancellation since SubMonitor.split() does that implicitly
  • Simplify work computation by avoiding unnecessary multiplies When creating a split SubMonitor the splitted child only operates on the assigned amount of work.

@github-actions
Copy link

github-actions bot commented Sep 2, 2023

Test Results

       9 files  ±0         9 suites  ±0   36m 58s ⏱️ - 1m 13s
2 175 tests ±0  2 171 ✔️ ±0    4 💤 ±0  0 ±0 
6 615 runs  ±0  6 604 ✔️ ±0  11 💤 ±0  0 ±0 

Results for commit 191e622. ± Comparison against base commit 5bf07ad.

♻️ This comment has been updated with latest results.

@HannesWell HannesWell force-pushed the monitorInProvContext branch 3 times, most recently from c5ca425 to 33c30a4 Compare September 11, 2023 19:56
- Use SubMonitor.split() over newChild()
- Remove explicit checks for cancellation since SubMonitor.split() does
that implicitly
- Simplify work computation by avoiding unnecessary multiplies
	When creating a split SubMonitor the splitted child only operates on
the assigned amount of work.
@HannesWell HannesWell merged commit 139d64e into eclipse-equinox:master Sep 11, 2023
7 checks passed
@HannesWell HannesWell deleted the monitorInProvContext branch September 11, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant