Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix "hiding" warnings #438

Merged
merged 1 commit into from
Jan 31, 2024
Merged

fix "hiding" warnings #438

merged 1 commit into from
Jan 31, 2024

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Jan 24, 2024

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited
Loading

Test Results

    9 files  ±0      9 suites  ±0   35m 18s ⏱️ + 3m 5s
2 183 tests ±0  2 179 ✅ ±0   4 💤 ±0  0 ❌ ±0 
6 639 runs  ±0  6 628 ✅ ±0  11 💤 ±0  0 ❌ ±0 

Results for commit 6464e7a. ± Comparison against base commit c055fef.

♻️ This comment has been updated with latest results.

@jukzi
Copy link
Contributor Author

jukzi commented Jan 31, 2024

@merks mind to review/submit?
compared to master removes dozens of warnings:
image

@merks
Copy link
Contributor

merks commented Jan 31, 2024

@jukzi Oh dear, a conflict. Sorry. 😢

@jukzi
Copy link
Contributor Author

jukzi commented Jan 31, 2024

@jukzi Oh dear, a conflict. Sorry. 😢

np, resolved

@merks merks merged commit 36fd2c4 into eclipse-equinox:master Jan 31, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merks merks merks left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jukzi @merks @EcljpseB0T