Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set UTF-8 encoding #441

Merged
merged 2 commits into from
Feb 1, 2024
Merged

set UTF-8 encoding #441

merged 2 commits into from
Feb 1, 2024

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Jan 31, 2024

solves "Project '' has no explicit encoding set"

solves "Project '' has no explicit encoding set"
Copy link

github-actions bot commented Jan 31, 2024

Test Results

    9 files  ±0      9 suites  ±0   30m 11s ⏱️ - 3m 54s
2 183 tests ±0  2 179 ✅ ±0   4 💤 ±0  0 ❌ ±0 
6 639 runs  ±0  6 628 ✅ ±0  11 💤 ±0  0 ❌ ±0 

Results for commit 344bec0. ± Comparison against base commit 36fd2c4.

♻️ This comment has been updated with latest results.

@merks
Copy link
Contributor

merks commented Feb 1, 2024

@laeubi @jukzi

It seems pretty much everything is failing. Some do appear to be related, e.g., this is probably because the jgit stamp changes but there are no other changes:

Error:  Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:4.0.5:compare-version-with-baselines (compare-attached-artifacts-with-release) on project org.eclipse.equinox.p2.garbagecollector: Only qualifier changed for (org.eclipse.equinox.p2.garbagecollector/1.3.100.v20240131-1530). Expected to have bigger x.y.z than what is available in baseline (1.3.100.v20230630-1506) -> [Help 1]

The javadoc looks to be in pretty bad shape. 😱

https://ci.eclipse.org/equinox/job/p2/job/PR-441/1/console

But even here, the overall failures are from baseline comparison problems that @jukzi will need to fix...

@merks
Copy link
Contributor

merks commented Feb 1, 2024

Was it intentional that you added a commit rather than amending and force pushing?

@jukzi
Copy link
Contributor Author

jukzi commented Feb 1, 2024

Was it intentional that you added a commit rather than amending and force pushing?

yes, some people prefer to have version bump in separate commit to make revert easier.

@jukzi
Copy link
Contributor Author

jukzi commented Feb 1, 2024

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-p2-director-plugin:4.0.5:archive-products (archive-products) on project org.eclipse.equinox.p2.reconciler: Error packing product: Problem creating zip: Execution exception: Java heap space -> [Help 1]

without commit rights i can not restart jenkins job

@merks
Copy link
Contributor

merks commented Feb 1, 2024

I can kick it, but sometimes for projects where I cannot, I just force push a tiny change to the commit comment.

@merks merks merged commit c123412 into eclipse-equinox:master Feb 1, 2024
8 of 9 checks passed
@merks
Copy link
Contributor

merks commented Feb 1, 2024

It was just some failure at the end packaging something that we don't need for anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants