Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TarFile: fix deprecated finalize() #443

Merged

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Feb 1, 2024

finalize() not needed - only used as autoclosable.

Copy link

github-actions bot commented Feb 1, 2024

Test Results

    9 files  ±0      9 suites  ±0   33m 51s ⏱️ + 1m 16s
2 183 tests ±0  2 179 ✅ ±0   4 💤 ±0  0 ❌ ±0 
6 639 runs  ±0  6 628 ✅ ±0  11 💤 ±0  0 ❌ ±0 

Results for commit cc8b9e2. ± Comparison against base commit fa81fb9.

♻️ This comment has been updated with latest results.

@jukzi
Copy link
Contributor Author

jukzi commented Feb 1, 2024

@merks
[ERROR] Failed to execute goal org.eclipse.tycho:tycho-p2-director-plugin:4.0.5:archive-products (archive-products) on project org.eclipse.equinox.p2.reconciler: Error packing product: Problem creating zip: Execution exception: Java heap space -> [Help 1]

finalize() not needed - only used as autoclosable.
@laeubi laeubi force-pushed the TarFile_fix_deprecated_finalize() branch from ffae061 to cc8b9e2 Compare February 10, 2024 06:03
@laeubi laeubi merged commit a4337e3 into eclipse-equinox:master Feb 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants