Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absence of an unpack attribute must not result in BundleShapeAdvice #477

Merged
merged 1 commit into from
Feb 29, 2024

Commits on Feb 29, 2024

  1. Absence of an unpack attribute must not result in BundleShapeAdvice

    Currently the FeaturesAction assumes that the unpack attribute is always
    set, if that is not the case it leads to unexpected results because then
    unpack=true is assumed always. This is especially dangerous as PDE since
    2023-12 release removes the attributes and Tycho assume they are false
    by default the same as PDE has done in the past when adding new items.
    
    To mitigate this this adds an additional check to only evaluate the
    unpack if it is set, together with a testcase that covers all possible
    combinations.
    laeubi committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    cf3265a View commit details
    Browse the repository at this point in the history