Enhance p2 director with "addJREIU" option.

[raghucssit]

P2 Director Application fails to install some of the bundles which has requirements on Java-SE 21. The reason for this issue was missing java profile dependency during installation. This new option includes Jre IU as an extra installable Unit.

Fixes #484

[merks]

The org.eclipse.equinox.p2.director.app project also needs a version increment.

Please try to consistently used JRE not Jre everywhere.

[merks]

I really have to review this in the IDE, but here are my comments so far.

[merks]

Just a nit that you can address if it's not too annoying.

[merks]

FYI, I kicked off another build here because the last one failed in a way that looked more like a build infrastructure problem.

https://ci.eclipse.org/equinox/job/p2/job/PR-486/

[merks]

The builds keep failing like this:

15:29:30 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.7-SNAPSHOT:verify (verify) on project org.eclipse.equinox.p2.publisher.eclipse: Execute ApiApplication failed: InvocationTargetException: Error reading manifest for /home/jenkins/agent/workspace/p2_PR-486/.m2/repository/p2/osgi/bundle/bcpg.source/1.77.0/bcpg.source-1.77.0.jar: zip file is empty -> [Help 1]

I think we should give it some time and I can manually kick off the build again later.

[github-actions]

Test Results

    9 files  ±0      9 suites  ±0   30m 20s ⏱️ - 1m 50s
2 184 tests ±0  2 180 ✅ ±0   4 💤 ±0  0 ❌ ±0 
6 642 runs  ±0  6 631 ✅ ±0  11 💤 ±0  0 ❌ ±0 

Results for commit 29dc915. ± Comparison against base commit e262a15.

♻️ This comment has been updated with latest results.

[merks]

It's still failing today. I'm going to create an "empty" PR to see if this is a general failure for all PRs.

[iloveeclipse]

I guess it simply needs a rebase?

[merks]

@iloveeclipse

It's failing like this:

07:29:34 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.7-SNAPSHOT:verify (verify) on project org.eclipse.equinox.p2.ui.discovery: Execute ApiApplication failed: InvocationTargetException: Error reading manifest for /home/jenkins/agent/workspace/p2_PR-486/.m2/repository/p2/osgi/bundle/bcprov.source/1.77.0/bcprov.source-1.77.0.jar: zip file is empty -> [Help 1]

I'm not sure how a rebase could help with that. I'm testing if it's reproducible using:

#488

[merks]

I've also tried to replay the pipeline adding -U as suggested by @HannesWell

[raghucssit]

I guess it simply needs a rebase?

I did rebase just now.. I will check if build succeeds..

[iloveeclipse]

I would assume the local maven cache is broken on Jenkins. @merks : should we just re-create and push a new PR, or is there a way to cleanup all the data in current jenkins workspace?

[merks]

Yes, something broken. My test PR worked. I don't know how to clean the cache. Maybe just some shell script. In any case, I created this new PR with the same content:

#489

[merks]

Strange. The build here is referring to the same build as the one for my new PR.

In any case, if the build for my PR passes we can commit from this PR and discard mine. Let's wait and see.

[iloveeclipse]

@merks : many thanks for review and help on the PR!