-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate reference to classes holding constants used in the code #2341
Generate reference to classes holding constants used in the code #2341
Conversation
fixes eclipse-jdt#1382 Emit a class constant into the constant pool for every class from which a constant is used.
@iloveeclipse results from API-Tools signal bytecode changes, indeed. This could cause quite a landslide of comparator errors in the SDK build. Please suggest how / when to proceed. As mentioned in the issue #1382 this will eliminate one small difference wrt javac. |
So if you are confident in this PR, feel free to merge and we can continue with points above. |
Actually you can touch affected JDT bundles already that make this PR red as of now. |
Switch to correct syntax for Class constant Also find constants within expressions as field initializers
@stephan-herrmann : if you plan to merge it today, please do it before 00:00 CET so the next build can pick it and we can start looking into "touching" bundles tomorrow without extra build. |
done
At that time I was already offline, and in fact I thought better not to mess up a Monday build (as those are the ones retained longer than other days, right?) - but then I got my timezone arithmetic wrong, so perhaps now I should indeed wait until the Monday build it good. |
@stephan-herrmann : just merge if you are done, if you wish, now. I can help next day to fix the SDK build. |
Thanks! |
…ipse-jdt#2341) fixes eclipse-jdt#1382 Emit a class constant into the constant pool for every class from which a constant is used. Touch bundles affected by this change
…ipse-jdt#2341) fixes eclipse-jdt#1382 Emit a class constant into the constant pool for every class from which a constant is used. Touch bundles affected by this change
fixes #1382
Emit a class constant into the constant pool for every class from which a constant is used.